fix: compute instance internal ipv6 prefix length is not set in creation and read in syncing (#13133) (#21638)

[upstream:2fb385974963dd1455d99b5bc25400a488b25111]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/13133.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fix `compute_instance.network_interface.internal_ipv6_prefix_length` not being set or read in Terraform state  
+```

google/services/compute/compute_instance_helpers.go

@@ -375,17 +375,18 @@ func flattenNetworkInterfaces(d *schema.ResourceData, config *transport_tpg.Conf
 		region = subnet.Region
 
 		flattened[i] = map[string]interface{}{
-			"network_ip":         iface.NetworkIP,
-			"network":            tpgresource.ConvertSelfLinkToV1(iface.Network),
-			"subnetwork":         tpgresource.ConvertSelfLinkToV1(iface.Subnetwork),
-			"subnetwork_project": subnet.Project,
-			"access_config":      ac,
-			"alias_ip_range":     flattenAliasIpRange(d, iface.AliasIpRanges, i),
-			"nic_type":           iface.NicType,
-			"stack_type":         iface.StackType,
-			"ipv6_access_config": flattenIpv6AccessConfigs(iface.Ipv6AccessConfigs),
-			"ipv6_address":       iface.Ipv6Address,
-			"queue_count":        iface.QueueCount,
+			"network_ip":                  iface.NetworkIP,
+			"network":                     tpgresource.ConvertSelfLinkToV1(iface.Network),
+			"subnetwork":                  tpgresource.ConvertSelfLinkToV1(iface.Subnetwork),
+			"subnetwork_project":          subnet.Project,
+			"access_config":               ac,
+			"alias_ip_range":              flattenAliasIpRange(d, iface.AliasIpRanges, i),
+			"nic_type":                    iface.NicType,
+			"stack_type":                  iface.StackType,
+			"ipv6_access_config":          flattenIpv6AccessConfigs(iface.Ipv6AccessConfigs),
+			"ipv6_address":                iface.Ipv6Address,
+			"queue_count":                 iface.QueueCount,
+			"internal_ipv6_prefix_length": iface.InternalIpv6PrefixLength,
 		}
 		// Instance template interfaces never have names, so they're absent
 		// in the instance template network_interface schema. We want to use the
@@ -486,17 +487,18 @@ func expandNetworkInterfaces(d tpgresource.TerraformResourceData, config *transp
 		}
 
 		ifaces[i] = &compute.NetworkInterface{
-			NetworkIP:         data["network_ip"].(string),
-			Network:           nf.RelativeLink(),
-			NetworkAttachment: networkAttachment,
-			Subnetwork:        sf.RelativeLink(),
-			AccessConfigs:     expandAccessConfigs(data["access_config"].([]interface{})),
-			AliasIpRanges:     expandAliasIpRanges(data["alias_ip_range"].([]interface{})),
-			NicType:           data["nic_type"].(string),
-			StackType:         data["stack_type"].(string),
-			QueueCount:        int64(data["queue_count"].(int)),
-			Ipv6AccessConfigs: expandIpv6AccessConfigs(data["ipv6_access_config"].([]interface{})),
-			Ipv6Address:       data["ipv6_address"].(string),
+			NetworkIP:                data["network_ip"].(string),
+			Network:                  nf.RelativeLink(),
+			NetworkAttachment:        networkAttachment,
+			Subnetwork:               sf.RelativeLink(),
+			AccessConfigs:            expandAccessConfigs(data["access_config"].([]interface{})),
+			AliasIpRanges:            expandAliasIpRanges(data["alias_ip_range"].([]interface{})),
+			NicType:                  data["nic_type"].(string),
+			StackType:                data["stack_type"].(string),
+			QueueCount:               int64(data["queue_count"].(int)),
+			Ipv6AccessConfigs:        expandIpv6AccessConfigs(data["ipv6_access_config"].([]interface{})),
+			Ipv6Address:              data["ipv6_address"].(string),
+			InternalIpv6PrefixLength: int64(data["internal_ipv6_prefix_length"].(int)),
 		}
 	}
 	return ifaces, nil

google/services/compute/resource_compute_instance_test.go

@@ -579,6 +579,30 @@ func TestAccComputeInstance_internalIPv6(t *testing.T) {
 	})
 }
 
+func TestAccComputeInstance_internalIPv6PrefixLength(t *testing.T) {
+	t.Parallel()
+
+	var instance compute.Instance
+	var instanceName = fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeInstanceDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeInstance_internalIpv6PrefixLength("96", instanceName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckComputeInstanceExists(
+						t, "google_compute_instance.foobar", &instance),
+					testAccCheckComputeInstanceIpv6AccessConfigHasInternalIPv6(&instance),
+				),
+			},
+			computeInstanceImportStep("us-west2-a", instanceName, []string{"allow_stopping_for_update"}),
+		},
+	})
+}
+
 func TestAccComputeInstance_PTRRecord(t *testing.T) {
 	t.Parallel()
 
@@ -5394,6 +5418,46 @@ func testAccComputeInstance_internalIpv6(ip, instance string) string {
   `, instance, instance, ip, instance)
 }
 
+func testAccComputeInstance_internalIpv6PrefixLength(length, instance string) string {
+	return fmt.Sprintf(`
+resource "google_compute_network" "vpc" {
+  name                     = "%s-network"
+  auto_create_subnetworks  = "false"
+  enable_ula_internal_ipv6 = true
+}
+
+resource "google_compute_subnetwork" "subnetwork" {
+  name             = "%s-subnetwork"
+  ip_cidr_range    = "10.0.0.0/22"
+  region           = "us-west2"
+  stack_type       = "IPV4_IPV6"
+  ipv6_access_type = "INTERNAL"
+  network          = google_compute_network.vpc.id
+}
+
+resource "google_compute_instance" "foobar" {
+  name                      = "%s"
+  machine_type              = "e2-micro"
+  allow_stopping_for_update = true
+  zone                      = "us-west2-a"
+  boot_disk {
+    auto_delete = false
+    initialize_params {
+      image = "debian-cloud/debian-11"
+    }
+  }
+  network_interface {
+    network    = google_compute_network.vpc.self_link
+    subnetwork = google_compute_subnetwork.subnetwork.self_link
+    stack_type = "IPV4_IPV6"
+    access_config {
+      network_tier = "STANDARD"
+    }
+    internal_ipv6_prefix_length = %s
+  }
+}
+`, instance, instance, instance, length)
+}
 func testAccComputeInstance_ipv6ExternalReservation(instance string) string {
 	return fmt.Sprintf(`
 resource "google_compute_address" "ipv6-address" {