Remove write-only resource validation warnings (#14385) (#23417)

[upstream:b2ddc6816d172ecaf87be6aa8fdf013912cfbe89]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/14385.txt

@@ -0,0 +1,9 @@
+```release-note:bug
+sql: no longer surface persistent warnings recommending write-only field when using `password` on `google_sql_user`
+```
+```release-note:bug
+secretmanager: no longer surface persistent warnings recommending write-only field when using `secret_data` on `google_secret_manager_secret_version`
+```
+```release-note:bug
+bigquerydatatransfer: no longer surface persistent warnings recommending write-only field when using `secret_access_key` on `google_bigquery_data_transfer_config`
+```

google/services/bigquerydatatransfer/resource_bigquery_data_transfer_config.go

@@ -32,7 +32,6 @@ import (
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 
 	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
 	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
@@ -135,9 +134,6 @@ func ResourceBigqueryDataTransferConfig() *schema.Resource {
 			paramsCustomizeDiff,
 			tpgresource.DefaultProviderProject,
 		),
-		ValidateRawResourceConfigFuncs: []schema.ValidateRawResourceConfigFunc{
-			validation.PreferWriteOnlyAttribute(cty.GetAttrPath("sensitive_params").IndexInt(0).GetAttr("secret_access_key"), cty.GetAttrPath("sensitive_params").IndexInt(0).GetAttr("secret_access_key_wo")),
-		},
 
 		Schema: map[string]*schema.Schema{
 			"data_source_id": {

google/services/secretmanager/resource_secret_manager_secret_version.go

@@ -31,7 +31,6 @@ import (
 
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 
 	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
 	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
@@ -90,10 +89,6 @@ func ResourceSecretManagerSecretVersion() *schema.Resource {
 			Delete: schema.DefaultTimeout(20 * time.Minute),
 		},
 
-		ValidateRawResourceConfigFuncs: []schema.ValidateRawResourceConfigFunc{
-			validation.PreferWriteOnlyAttribute(cty.GetAttrPath("secret_data"), cty.GetAttrPath("secret_data_wo")),
-		},
-
 		Schema: map[string]*schema.Schema{
 			"secret_data_wo_version": {
 				Type:        schema.TypeInt,

google/services/sql/resource_sql_user.go

@@ -78,10 +78,6 @@ func ResourceSqlUser() *schema.Resource {
 			tpgresource.DefaultProviderProject,
 		),
 
-		ValidateRawResourceConfigFuncs: []schema.ValidateRawResourceConfigFunc{
-			validation.PreferWriteOnlyAttribute(cty.GetAttrPath("password"), cty.GetAttrPath("password_wo")),
-		},
-
 		SchemaVersion: 1,
 		MigrateState:  resourceSqlUserMigrateState,