feat: (storage) added time_created and updated timestamps for storage bucket (#13763) (#22500)

[upstream:56d67adbf83210d2f344472c5d89fefe0fc6c5eb]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/13763.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+storage: added new fields `time_created` and `updated` in `google_storage_bucket`
+```

google/services/storage/resource_storage_bucket.go

@@ -568,6 +568,16 @@ func ResourceStorageBucket() *schema.Resource {
 					},
 				},
 			},
+			"time_created": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: `The creation time of the bucket in RFC 3339 format.`,
+			},
+			"updated": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: `The time at which the bucket's metadata or IAM policy was last updated, in RFC 3339 format.`,
+			},
 		},
 		UseJSONNumber: true,
 	}
@@ -1308,6 +1318,14 @@ func flattenBucketCustomPlacementConfig(cfc *storage.BucketCustomPlacementConfig
 	return customPlacementConfig
 }
 
+func flattenTimeCreated(v interface{}) interface{} {
+	return v
+}
+
+func flattenUpdated(v interface{}) interface{} {
+	return v
+}
+
 func expandBucketDataLocations(configured interface{}) []string {
 	l := configured.(*schema.Set).List()
 
@@ -2034,6 +2052,12 @@ func setStorageBucket(d *schema.ResourceData, config *transport_tpg.Config, res
 	if err := d.Set("custom_placement_config", flattenBucketCustomPlacementConfig(res.CustomPlacementConfig)); err != nil {
 		return fmt.Errorf("Error setting custom_placement_config: %s", err)
 	}
+	if err := d.Set("time_created", flattenTimeCreated(res.TimeCreated)); err != nil {
+		return fmt.Errorf("Error setting time_created: %s", err)
+	}
+	if err := d.Set("updated", flattenUpdated(res.Updated)); err != nil {
+		return fmt.Errorf("Error setting updated: %s", err)
+	}
 	// Needs to hide rpo field for single-region buckets.
 	// Check the Rpo field from API response to determine whether bucket is in single region config or not.
 	if res.Rpo != "" {

google/services/storage/resource_storage_bucket_test.go

@@ -42,6 +42,10 @@ func TestAccStorageBucket_basic(t *testing.T) {
 						"google_storage_bucket.bucket", "project_number"),
 					resource.TestCheckResourceAttr(
 						"google_storage_bucket.bucket", "rpo", "DEFAULT"),
+					resource.TestCheckResourceAttrSet(
+						"google_storage_bucket.bucket", "time_created"),
+					resource.TestCheckResourceAttrSet(
+						"google_storage_bucket.bucket", "updated"),
 				),
 			},
 			{

website/docs/r/storage_bucket.html.markdown

@@ -173,6 +173,10 @@ The following arguments are supported:
 
 * `hierarchical_namespace` -  (Optional, ForceNew) The bucket's hierarchical namespace policy, which defines the bucket capability to handle folders in logical structure. Structure is [documented below](#nested_hierarchical_namespace). To use this configuration, `uniform_bucket_level_access` must be enabled on bucket.
 
+* `time_created` -  (Computed) The creation time of the bucket in RFC 3339 format.
+
+* `updated` -  (Computed) The time at which the bucket's metadata or IAM policy was last updated, in RFC 3339 format.
+
 <a name="nested_lifecycle_rule"></a>The `lifecycle_rule` block supports:
 
 * `action` - (Required) The Lifecycle Rule's action configuration. A single block of this type is supported. Structure is [documented below](#nested_action).