Skip to content

Commit b78e616

Browse files
Removed some more stale TODO assignments and standardized on TODO instead of NOTE (#14644) (#23722)
[upstream:869cda327d7e21196577aed97c31142abb0c7130] Signed-off-by: Modular Magician <[email protected]>
1 parent f4e1f7a commit b78e616

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

google/services/resourcemanager/resource_google_project.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -790,7 +790,7 @@ func doEnableServicesRequest(services []string, project, billingProject, userAge
790790
// Handle errors that are retryable at call time for serviceusage
791791
// Specifically, errors in https://cloud.google.com/service-usage/docs/reference/rest/v1/services/batchEnable#response-body
792792
// Errors in operations are handled separately.
793-
// NOTE(rileykarson): This should probably be turned into a retry predicate
793+
// TODO: This should probably be turned into a retry predicate
794794
func handleServiceUsageRetryablePreconditionError(err error) error {
795795
if err == nil {
796796
return nil

google/services/servicenetworking/resource_google_service_networking_peered_dns_domain.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ func resourceGoogleServiceNetworkingPeeredDNSDomainDelete(d *schema.ResourceData
256256
return nil
257257
}
258258

259-
// NOTE(deviavir): An out of band aspect of this API is that it uses a unique formatting of network
259+
// TODO: An out of band aspect of this API is that it uses a unique formatting of network
260260
// different from the standard self_link URI. It requires a call to the resource manager to get the project
261261
// number for the current project.
262262
func getProjectNumber(d *schema.ResourceData, config *transport_tpg.Config, project, userAgent string) (string, error) {

google/services/servicenetworking/resource_service_networking_connection.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func ResourceServiceNetworkingConnection() *schema.Resource {
5757
DiffSuppressFunc: tpgresource.CompareSelfLinkOrResourceName,
5858
Description: `Name of VPC network connected with service producers using VPC peering.`,
5959
},
60-
// NOTE(craigatgoogle): This field is weird, it's required to make the Insert/List calls as a parameter
60+
// TODO: This field is weird, it's required to make the Insert/List calls as a parameter
6161
// named "parent", however it's also defined in the response as an output field called "peering", which
6262
// uses "-" as a delimiter instead of ".". To alleviate user confusion I've opted to model the gcloud
6363
// CLI's approach, calling the field "service" and accepting the same format as the CLI with the "."
@@ -357,7 +357,7 @@ func resourceServiceNetworkingConnectionImportState(d *schema.ResourceData, meta
357357
return []*schema.ResourceData{d}, nil
358358
}
359359

360-
// NOTE(craigatgoogle): The Connection resource in this API doesn't have an Id field, so inorder
360+
// TODO: The Connection resource in this API doesn't have an Id field, so inorder
361361
// to support the Read method, we create an Id using the tuple(Network, Service).
362362
type connectionId struct {
363363
Network string
@@ -395,7 +395,7 @@ func parseConnectionId(id string) (*connectionId, error) {
395395
}, nil
396396
}
397397

398-
// NOTE(craigatgoogle): An out of band aspect of this API is that it uses a unique formatting of network
398+
// TODO: An out of band aspect of this API is that it uses a unique formatting of network
399399
// different from the standard self_link URI. It requires a call to the resource manager to get the project
400400
// number for the current project.
401401
func RetrieveServiceNetworkingNetworkName(d *schema.ResourceData, config *transport_tpg.Config, network, userAgent string) (string, error) {
@@ -438,7 +438,7 @@ func RetrieveServiceNetworkingNetworkName(d *schema.ResourceData, config *transp
438438

439439
const parentServicePattern = "^services/.+$"
440440

441-
// NOTE(craigatgoogle): An out of band aspect of this API is that it requires the service name to be
441+
// TODO: An out of band aspect of this API is that it requires the service name to be
442442
// formatted as "services/<serviceName>"
443443
func formatParentService(service string) string {
444444
r := regexp.MustCompile(parentServicePattern)

0 commit comments

Comments
 (0)