Skip to content

Commit bb230c1

Browse files
Fixed cluster resource limits maximum to be marked as required in docs. (#12777) (#21051)
[upstream:efb7d4653f9f5ebfea45622b89c8b56aa8a354f1] Signed-off-by: Modular Magician <[email protected]>
1 parent edeb3c8 commit bb230c1

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.changelog/12777.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
container: marked `cluster_autoscaling.resource_limits.maximum` as required as requests would fail if it was not set
3+
```

google/services/container/resource_container_cluster.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -579,9 +579,10 @@ func ResourceContainerCluster() *schema.Resource {
579579
Description: `Minimum amount of the resource in the cluster.`,
580580
},
581581
"maximum": {
582-
Type: schema.TypeInt,
583-
Optional: true,
584-
Description: `Maximum amount of the resource in the cluster.`,
582+
Type: schema.TypeInt,
583+
Description: `Maximum amount of the resource in the cluster.`,
584+
Required: true,
585+
ValidateFunc: validation.IntAtLeast(1),
585586
},
586587
},
587588
},

website/docs/r/container_cluster.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ for a list of types.
582582

583583
* `minimum` - (Optional) Minimum amount of the resource in the cluster.
584584

585-
* `maximum` - (Optional) Maximum amount of the resource in the cluster.
585+
* `maximum` - (Required) Maximum amount of the resource in the cluster.
586586

587587
<a name="nested_auto_provisioning_defaults"></a>The `auto_provisioning_defaults` block supports:
588588

0 commit comments

Comments
 (0)