Wait for write propagation after creating an OS Login SSH key (#13353) (#21860)

modular-magician · web-flow · commit bd2acc077010 · 2025-03-13T13:22:19.000-07:00
[upstream:8fc9e7eced066cd3d0118031b4723c253beaac7d]

Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/13353.txt b/.changelog/13353.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+oslogin: added a wait after creating `google_os_login_ssh_public_key`.
+```
diff --git a/google/services/oslogin/resource_os_login_ssh_public_key.go b/google/services/oslogin/resource_os_login_ssh_public_key.go
@@ -171,6 +171,9 @@ func resourceOSLoginSSHPublicKeyCreate(d *schema.ResourceData, meta interface{})
 	}
 	d.SetId(id)
 
+	// Wait 10s for write propagation; should be usually done in ~7s max.
+	time.Sleep(10 * time.Second)
+
 	log.Printf("[DEBUG] Finished creating SSHPublicKey %q: %#v", d.Id(), res)
 
 	return resourceOSLoginSSHPublicKeyRead(d, meta)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:enhancement
	`2`	+oslogin: added a wait after creating `google_os_login_ssh_public_key`.
	`3`	+```
Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,9 @@ func resourceOSLoginSSHPublicKeyCreate(d *schema.ResourceData, meta interface{})`
`171`	`171`	`}`
`172`	`172`	`d.SetId(id)`
`173`	`173`
	`174`	`+ // Wait 10s for write propagation; should be usually done in ~7s max.`
	`175`	`+ time.Sleep(10 * time.Second)`
	`176`	`+`
`174`	`177`	`log.Printf("[DEBUG] Finished creating SSHPublicKey %q: %#v", d.Id(), res)`
`175`	`178`
`176`	`179`	`return resourceOSLoginSSHPublicKeyRead(d, meta)`