Lakshman single datasource generation (#14598) (#23919)

[upstream:88a3b9b9f43c264719d2069e26b622d8e64149bc]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

google/provider/provider_mmv1_resources.go

@@ -305,7 +305,7 @@ var handwrittenDatasources = map[string]*schema.Resource{
 	"google_iam_testable_permissions":                            resourcemanager.DataSourceGoogleIamTestablePermissions(),
 	"google_iam_workload_identity_pool":                          iambeta.DataSourceIAMBetaWorkloadIdentityPool(),
 	"google_iam_workload_identity_pool_provider":                 iambeta.DataSourceIAMBetaWorkloadIdentityPoolProvider(),
-	"google_iap_client":                                          iap.DataSourceGoogleIapClient(),
+	"google_iap_client":                                          iap.DataSourceIapClient(),
 	"google_kms_crypto_key":                                      kms.DataSourceGoogleKmsCryptoKey(),
 	"google_kms_crypto_keys":                                     kms.DataSourceGoogleKmsCryptoKeys(),
 	"google_kms_crypto_key_version":                              kms.DataSourceGoogleKmsCryptoKeyVersion(),

google/services/iap/data_source_iap_client.go

@@ -1,14 +1,16 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
+
 // ----------------------------------------------------------------------------
 //
-//	***     AUTO GENERATED CODE    ***    Type: Handwritten     ***
+//	***     AUTO GENERATED CODE    ***    Type: MMv1     ***
 //
 // ----------------------------------------------------------------------------
 //
 //	This code is generated by Magic Modules using the following:
 //
-//	Source file: https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/services/iap/data_source_iap_client.go
+//	Configuration: https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/products/iap/Client.yaml
+//	Template:      https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/templates/terraform/datasource.go.tmpl
 //
 //	DO NOT EDIT this file directly. Any changes made to this file will be
 //	overwritten during the next generation cycle.
@@ -20,29 +22,37 @@ import (
 	"fmt"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+
 	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
 	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
 )
 
-func DataSourceGoogleIapClient() *schema.Resource {
+func DataSourceIapClient() *schema.Resource {
+	rs := ResourceIapClient().Schema
 
-	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(ResourceIapClient().Schema)
+	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(rs)
+
+	// Set 'Required' schema elements
 	tpgresource.AddRequiredFieldsToSchema(dsSchema, "brand", "client_id")
 
+	// Set 'Optional' schema elements
+	tpgresource.AddOptionalFieldsToSchema(dsSchema)
+
 	return &schema.Resource{
-		Read:   dataSourceGoogleIapClientRead,
+		Read:   dataSourceIapClientRead,
 		Schema: dsSchema,
 	}
 }
 
-func dataSourceGoogleIapClientRead(d *schema.ResourceData, meta interface{}) error {
+func dataSourceIapClientRead(d *schema.ResourceData, meta interface{}) error {
 	config := meta.(*transport_tpg.Config)
 
 	id, err := tpgresource.ReplaceVars(d, config, "{{brand}}/identityAwareProxyClients/{{client_id}}")
 	if err != nil {
-		return fmt.Errorf("Error constructing id: %s", err)
+		return err
 	}
 	d.SetId(id)
+
 	err = resourceIapClientRead(d, meta)
 	if err != nil {
 		return err
@@ -51,5 +61,6 @@ func dataSourceGoogleIapClientRead(d *schema.ResourceData, meta interface{}) err
 	if d.Id() == "" {
 		return fmt.Errorf("%s not found", id)
 	}
+
 	return nil
 }