Skip to content

Commit cb0b50e

Browse files
Update ManagedZone.yaml and add domain name to forwarding config and make ipv4Address optional (#13182) (#22419)
[upstream:59d9456a4f0f196e1d7611d2246b81ffa1f57542] Signed-off-by: Modular Magician <[email protected]>
1 parent 1c2ec12 commit cb0b50e

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

.changelog/13182.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
dns: added `target_name_servers.domainName` to resource`google_dns_managed_zone ` (beta)
3+
```

google/services/dns/resource_dns_managed_zone.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -369,11 +369,6 @@ This should be formatted like 'projects/{project}/global/networks/{network}' or
369369
func dnsManagedZoneForwardingConfigTargetNameServersSchema() *schema.Resource {
370370
return &schema.Resource{
371371
Schema: map[string]*schema.Schema{
372-
"ipv4_address": {
373-
Type: schema.TypeString,
374-
Required: true,
375-
Description: `IPv4 address of a target name server.`,
376-
},
377372
"forwarding_path": {
378373
Type: schema.TypeString,
379374
Optional: true,
@@ -382,6 +377,11 @@ func dnsManagedZoneForwardingConfigTargetNameServersSchema() *schema.Resource {
382377
decision based on address ranges, i.e. RFC1918 addresses go to the VPC, Non-RFC1918 addresses go
383378
to the Internet. When set to 'private', Cloud DNS will always send queries through VPC for this target Possible values: ["default", "private"]`,
384379
},
380+
"ipv4_address": {
381+
Type: schema.TypeString,
382+
Optional: true,
383+
Description: `IPv4 address of a target name server.`,
384+
},
385385
},
386386
}
387387
}

website/docs/r/dns_managed_zone.html.markdown

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,9 +494,13 @@ The following arguments are supported:
494494
<a name="nested_forwarding_config_target_name_servers"></a>The `target_name_servers` block supports:
495495

496496
* `ipv4_address` -
497-
(Required)
497+
(Optional)
498498
IPv4 address of a target name server.
499499

500+
* `domain_name` -
501+
(Optional, [Beta](https://terraform.io/docs/providers/google/guides/provider_versions.html))
502+
Fully qualified domain name for the forwarding target.
503+
500504
* `forwarding_path` -
501505
(Optional)
502506
Forwarding path for this TargetNameServer. If unset or `default` Cloud DNS will make forwarding

0 commit comments

Comments
 (0)