Skip to content

Commit e12bb4c

Browse files
Made filestore backup tests use sweepable resources (#13009) (#21317)
[upstream:37390d359c66e0c8c4917fe8a4be1d5dab6440c2] Signed-off-by: Modular Magician <[email protected]>
1 parent 76e2d83 commit e12bb4c

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

.changelog/13009.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:none
2+
3+
```

google/services/filestore/resource_filestore_backup_generated_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func TestAccFilestoreBackup_filestoreBackupBasicExample(t *testing.T) {
5858
func testAccFilestoreBackup_filestoreBackupBasicExample(context map[string]interface{}) string {
5959
return acctest.Nprintf(`
6060
resource "google_filestore_instance" "instance" {
61-
name = "tf-test-tf-fs-inst%{random_suffix}"
61+
name = "tf-test-fs-inst%{random_suffix}"
6262
location = "us-central1-b"
6363
tier = "BASIC_HDD"
6464
@@ -75,7 +75,7 @@ resource "google_filestore_instance" "instance" {
7575
}
7676
7777
resource "google_filestore_backup" "backup" {
78-
name = "tf-test-tf-fs-bkup%{random_suffix}"
78+
name = "tf-test-fs-bkup%{random_suffix}"
7979
location = "us-central1"
8080
description = "This is a filestore backup for the test instance"
8181
source_instance = google_filestore_instance.instance.id

google/services/filestore/resource_filestore_backup_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import (
1414
func TestAccFilestoreBackup_update(t *testing.T) {
1515
t.Parallel()
1616

17-
instName := fmt.Sprintf("tf-fs-inst-%d", acctest.RandInt(t))
18-
bkupName := fmt.Sprintf("tf-fs-bkup-%d", acctest.RandInt(t))
17+
instName := fmt.Sprintf("tf-test-fs-inst-%d", acctest.RandInt(t))
18+
bkupName := fmt.Sprintf("tf-test-fs-bkup-%d", acctest.RandInt(t))
1919

2020
acctest.VcrTest(t, resource.TestCase{
2121
PreCheck: func() { acctest.AccTestPreCheck(t) },
@@ -121,8 +121,8 @@ func TestAccFilestoreBackup_tags(t *testing.T) {
121121
t.Parallel()
122122

123123
org := envvar.GetTestOrgFromEnv(t)
124-
instanceName := fmt.Sprintf("tf-fs-inst-%d", acctest.RandInt(t))
125-
backupName := fmt.Sprintf("tf-fs-bkup-%d", acctest.RandInt(t))
124+
instanceName := fmt.Sprintf("tf-test-fs-inst-%d", acctest.RandInt(t))
125+
backupName := fmt.Sprintf("tf-test-fs-bkup-%d", acctest.RandInt(t))
126126
tagKey := acctest.BootstrapSharedTestTagKey(t, "filestore-backups-tagkey")
127127
tagValue := acctest.BootstrapSharedTestTagValue(t, "filestore-backups-tagvalue", tagKey)
128128

website/docs/r/filestore_backup.html.markdown

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ To get more information about Backup, see:
3939

4040
```hcl
4141
resource "google_filestore_instance" "instance" {
42-
name = "tf-fs-inst"
42+
name = "fs-inst"
4343
location = "us-central1-b"
4444
tier = "BASIC_HDD"
4545
@@ -56,7 +56,7 @@ resource "google_filestore_instance" "instance" {
5656
}
5757
5858
resource "google_filestore_backup" "backup" {
59-
name = "tf-fs-bkup"
59+
name = "fs-bkup"
6060
location = "us-central1"
6161
description = "This is a filestore backup for the test instance"
6262
source_instance = google_filestore_instance.instance.id

0 commit comments

Comments
 (0)