GetProjectFromRegionalSelfLink: Accept projects with a colon in the name (#12628) (#20789)

[upstream:f5e373575e0c43293f7f4a2402e90bc960c5d03b]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/12628.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+compute: GetProjectFromRegionalSelfLink accepts projects with a colon in the name
+```

google/tpgresource/self_link_helpers.go

@@ -174,7 +174,7 @@ func GetRegionFromRegionalSelfLink(selfLink string) string {
 }
 
 func GetProjectFromRegionalSelfLink(selfLink string) string {
-	re := regexp.MustCompile("projects/([a-zA-Z0-9-]*)/(?:locations|regions)/[a-zA-Z0-9-]*")
+	re := regexp.MustCompile("projects/([a-zA-Z0-9-:]*)/(?:locations|regions)/[a-zA-Z0-9-:]*")
 	switch {
 	case re.MatchString(selfLink):
 		if res := re.FindStringSubmatch(selfLink); len(res) == 2 && res[1] != "" {

google/tpgresource/self_link_helpers_test.go

@@ -127,8 +127,9 @@ func TestGetRegionFromRegionalSelfLink(t *testing.T) {
 
 func TestGetProjectFromRegionalSelfLink(t *testing.T) {
 	cases := map[string]string{
-		"projects/foo/locations/europe-north1/datasets/bar/operations/foobar":        "foo",
-		"projects/REDACTED/regions/europe-north1/subnetworks/tf-test-net-xbwhsmlfm8": "REDACTED",
+		"projects/foo/locations/europe-north1/datasets/bar/operations/foobar":            "foo",
+		"projects/REDACTED/regions/europe-north1/subnetworks/tf-test-net-xbwhsmlfm8":     "REDACTED",
+		"projects/REDA:CT-ED09/regions/europe-north1/subnetworks/tf-test-net-xbwhsmlfm8": "REDA:CT-ED09",
 	}
 	for input, expected := range cases {
 		if result := GetProjectFromRegionalSelfLink(input); result != expected {