Removed stale TODO assignments (#14631) (#23713)

[upstream:5a5a4ef93b9e393c9a1a6f8e6e394f8ee07e69f0]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

google/acctest/bootstrap_test_utils.go

@@ -401,7 +401,7 @@ func BootstrapKMSKeyWithPurposeInLocationAndName(t *testing.T, purpose, location
 		t.Fatalf("Unable to bootstrap KMS key. CryptoKey is nil!")
 	}
 
-	// TODO(b/372305432): Use the pagination properly.
+	// TODO: b/372305432 Use the pagination properly.
 	ckvResp, err := kmsClient.Projects.Locations.KeyRings.CryptoKeys.CryptoKeyVersions.List(keyName).Do()
 	if err != nil {
 		t.Fatalf("Unable to list cryptoKeyVersions: %v", err)

google/fwresource/framework_location.go

@@ -86,7 +86,7 @@ func (ld *LocationDescription) GetLocation() (types.String, error) {
 }
 
 func (ld *LocationDescription) GetRegion() (types.String, error) {
-	// TODO(SarahFrench): Make empty strings not ignored, see https://github.com/hashicorp/terraform-provider-google/issues/14447
+	// TODO: Make empty strings not ignored, see https://github.com/hashicorp/terraform-provider-google/issues/14447
 	// For all checks in this function body
 
 	// Region from resource config
@@ -120,7 +120,7 @@ func (ld *LocationDescription) GetRegion() (types.String, error) {
 }
 
 func (ld *LocationDescription) GetZone() (types.String, error) {
-	// TODO(SarahFrench): Make empty strings not ignored, see https://github.com/hashicorp/terraform-provider-google/issues/14447
+	// TODO: Make empty strings not ignored, see https://github.com/hashicorp/terraform-provider-google/issues/14447
 	// For all checks in this function body
 
 	if !ld.ResourceZone.IsNull() && !ld.ResourceZone.IsUnknown() && !ld.ResourceZone.Equal(types.StringValue("")) {

google/services/beyondcorp/iam_beyondcorp_application_generated_test.go

@@ -314,7 +314,7 @@ func TestAccBeyondcorpApplicationIamPolicyGenerated_withCondition(t *testing.T)
 			{
 				Config: testAccBeyondcorpApplicationIamPolicy_withConditionGenerated(context),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					// TODO(SarahFrench) - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
+					// TODO - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
 					// resource.TestCheckResourceAttr("data.google_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttr("google_beyondcorp_application_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttrWith("data.google_iam_policy.foo", "policy_data", tpgresource.CheckGoogleIamPolicy),

google/services/beyondcorp/iam_beyondcorp_security_gateway_application_generated_test.go

@@ -314,7 +314,7 @@ func TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition
 			{
 				Config: testAccBeyondcorpSecurityGatewayApplicationIamPolicy_withConditionGenerated(context),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					// TODO(SarahFrench) - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
+					// TODO - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
 					// resource.TestCheckResourceAttr("data.google_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttr("google_beyondcorp_security_gateway_application_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttrWith("data.google_iam_policy.foo", "policy_data", tpgresource.CheckGoogleIamPolicy),

google/services/beyondcorp/iam_beyondcorp_security_gateway_generated_test.go

@@ -314,7 +314,7 @@ func TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition(t *testing
 			{
 				Config: testAccBeyondcorpSecurityGatewayIamPolicy_withConditionGenerated(context),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					// TODO(SarahFrench) - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
+					// TODO - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
 					// resource.TestCheckResourceAttr("data.google_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttr("google_beyondcorp_security_gateway_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttrWith("data.google_iam_policy.foo", "policy_data", tpgresource.CheckGoogleIamPolicy),

google/services/bigtable/resource_bigtable_instance_test.go

@@ -212,7 +212,7 @@ func TestAccBigtableInstance_kms(t *testing.T) {
 				ImportStateVerify:       true,
 				ImportStateVerifyIgnore: []string{"deletion_protection", "instance_type"}, // we don't read instance type back
 			},
-			// TODO(kevinsi4508): Verify that the instance can be recreated due to `kms_key_name` change.
+			// TODO: Verify that the instance can be recreated due to `kms_key_name` change.
 			{
 				Config:             testAccBigtableInstance_kms(pid, instanceName, kms2.CryptoKey.Name, 3),
 				PlanOnly:           true,

google/services/bigtable/resource_bigtable_table.go

@@ -698,7 +698,7 @@ func FlattenColumnFamily(families []bigtable.FamilyInfo) ([]map[string]interface
 	return result, nil
 }
 
-// TODO(rileykarson): Fix the stored import format after rebasing 3.0.0
+// TODO: Fix the stored import format after rebasing 3.0.0
 func resourceBigtableTableImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
 	config := meta.(*transport_tpg.Config)
 	if err := tpgresource.ParseImportId([]string{

google/services/composer/resource_composer_environment_test.go

@@ -132,7 +132,7 @@ func TestAccComposerEnvironment_withEncryptionConfigComposer2(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -166,7 +166,7 @@ func TestAccComposerEnvironment_withMaintenanceWindow(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -237,7 +237,7 @@ func TestAccComposerEnvironment_ComposerV2(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -274,7 +274,7 @@ func TestAccComposerEnvironment_UpdateComposerV2ImageVersion(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -311,7 +311,7 @@ func TestAccComposerEnvironment_UpdateComposerV2ResilienceMode(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -345,7 +345,7 @@ func TestAccComposerEnvironment_ComposerV2HighResilience(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -382,7 +382,7 @@ func TestAccComposerEnvironment_UpdateComposerV2WithTriggerer(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -419,7 +419,7 @@ func TestAccComposerEnvironment_UpdateComposerV2(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -453,7 +453,7 @@ func TestAccComposerEnvironment_composerV2PrivateServiceConnect(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -487,7 +487,7 @@ func TestAccComposerEnvironment_composerV2MasterAuthNetworks(t *testing.T) {
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,
@@ -524,7 +524,7 @@ func TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate(t *testing.T)
 			},
 			// This is a terrible clean-up step in order to get destroy to succeed,
 			// due to dangling firewall rules left by the Composer Environment blocking network deletion.
-			// TODO(dzarmola): Remove this check if firewall rules bug gets fixed by Composer.
+			// TODO: Remove this check if firewall rules bug gets fixed by Composer.
 			{
 				PlanOnly:           true,
 				ExpectNonEmptyPlan: false,

google/services/compute/iam_compute_image_generated_test.go

@@ -314,7 +314,7 @@ func TestAccComputeImageIamPolicyGenerated_withCondition(t *testing.T) {
 			{
 				Config: testAccComputeImageIamPolicy_withConditionGenerated(context),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					// TODO(SarahFrench) - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
+					// TODO - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
 					// resource.TestCheckResourceAttr("data.google_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttr("google_compute_image_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttrWith("data.google_iam_policy.foo", "policy_data", tpgresource.CheckGoogleIamPolicy),

google/services/compute/iam_compute_instance_generated_test.go

@@ -314,7 +314,7 @@ func TestAccComputeInstanceIamPolicyGenerated_withCondition(t *testing.T) {
 			{
 				Config: testAccComputeInstanceIamPolicy_withConditionGenerated(context),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					// TODO(SarahFrench) - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
+					// TODO - uncomment once https://github.com/GoogleCloudPlatform/magic-modules/pull/6466 merged
 					// resource.TestCheckResourceAttr("data.google_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttr("google_compute_instance_iam_policy.foo", "policy_data", expectedPolicyData),
 					resource.TestCheckResourceAttrWith("data.google_iam_policy.foo", "policy_data", tpgresource.CheckGoogleIamPolicy),