Skip to content

Commit f1b43e3

Browse files
replaced selfsubjectreviews with resourceclaims for beta api test, selfsubjectreviews was GAed, and its beta API was removed (#14755) (#23896)
[upstream:c90000202ce2c0b5d0d660e96c2db78f5547b2bd] Signed-off-by: Modular Magician <[email protected]>
1 parent 2603922 commit f1b43e3

File tree

1 file changed

+12
-16
lines changed

1 file changed

+12
-16
lines changed

google/services/container/resource_container_cluster_test.go

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -10426,28 +10426,24 @@ resource "google_container_cluster" "primary" {
1042610426
min_master_version = data.google_container_engine_versions.uscentral1a.release_channel_latest_version["STABLE"]
1042710427
initial_node_count = 1
1042810428
10429-
# This feature has been available since GKE 1.27, and currently the only
10430-
# supported Beta API is authentication.k8s.io/v1beta1/selfsubjectreviews.
10431-
# However, in the future, more Beta APIs will be supported, such as the
10432-
# resource.k8s.io group. At the same time, some existing Beta APIs will be
10433-
# deprecated as the feature will be GAed, and the Beta API will be eventually
10434-
# removed. In the case of the SelfSubjectReview API, it is planned to be GAed
10435-
# in Kubernetes as of 1.28. And, the Beta API of SelfSubjectReview will be removed
10436-
# after at least 3 minor version bumps, so it will be removed as of Kubernetes 1.31
10437-
# or later.
10438-
# https://pr.k8s.io/117713
10429+
# Some existing Beta APIs will be deprecated as the feature will be GAed,
10430+
# and the Beta API will be eventually removed. In the case of the ResourceClaims
10431+
# and its depended APIs, they are GAed in Kubernetes as of 1.34. And, the Beta APIs
10432+
# will be removed after at least 3 minor version bumps, so it will be removed as
10433+
# of Kubernetes 1.37 or later.
10434+
# https://pr.k8s.io/132706
1043910435
# https://kubernetes.io/docs/reference/using-api/deprecation-guide/
1044010436
#
10441-
# The new Beta APIs will be available since GKE 1.28
10442-
# - admissionregistration.k8s.io/v1beta1/validatingadmissionpolicies
10443-
# - admissionregistration.k8s.io/v1beta1/validatingadmissionpolicybindings
10444-
# https://pr.k8s.io/118644
10445-
#
1044610437
# Removing the Beta API from Kubernetes will break the test.
1044710438
# TODO: Replace the Beta API with one available on the version of GKE
1044810439
# if the test is broken.
1044910440
enable_k8s_beta_apis {
10450-
enabled_apis = ["authentication.k8s.io/v1beta1/selfsubjectreviews"]
10441+
enabled_apis = [
10442+
"resource.k8s.io/v1beta1/deviceclasses",
10443+
"resource.k8s.io/v1beta1/resourceclaims",
10444+
"resource.k8s.io/v1beta1/resourceclaimtemplates",
10445+
"resource.k8s.io/v1beta1/resourceslices"
10446+
]
1045110447
}
1045210448
network = "%s"
1045310449
subnetwork = "%s"

0 commit comments

Comments
 (0)