Make LinkedVpcNetwork mutable (#14757) (#23949)

[upstream:f8458f0f629c654db38142f293872365a828d9f5]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/14757.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+networkconnectivity: added update support for `linked_vpc_network` in `google_network_connectivity_spoke`
+```

google/services/networkconnectivity/resource_network_connectivity_spoke.go

@@ -228,7 +228,6 @@ The only allowed value for now is "ALL_IPV4_RANGES".`,
 			"linked_vpc_network": {
 				Type:        schema.TypeList,
 				Optional:    true,
-				ForceNew:    true,
 				Description: `VPC network that is associated with the spoke.`,
 				MaxItems:    1,
 				Elem: &schema.Resource{
@@ -626,6 +625,12 @@ func resourceNetworkConnectivitySpokeUpdate(d *schema.ResourceData, meta interfa
 	} else if v, ok := d.GetOkExists("linked_router_appliance_instances"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, linkedRouterApplianceInstancesProp)) {
 		obj["linkedRouterApplianceInstances"] = linkedRouterApplianceInstancesProp
 	}
+	linkedVpcNetworkProp, err := expandNetworkConnectivitySpokeLinkedVpcNetwork(d.Get("linked_vpc_network"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("linked_vpc_network"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, linkedVpcNetworkProp)) {
+		obj["linkedVpcNetwork"] = linkedVpcNetworkProp
+	}
 	labelsProp, err := expandNetworkConnectivitySpokeEffectiveLabels(d.Get("effective_labels"), d, config)
 	if err != nil {
 		return err
@@ -659,6 +664,11 @@ func resourceNetworkConnectivitySpokeUpdate(d *schema.ResourceData, meta interfa
 			"linkedRouterApplianceInstances.includeImportRanges")
 	}
 
+	if d.HasChange("linked_vpc_network") {
+		updateMask = append(updateMask, "linkedVpcNetwork.excludeExportRanges",
+			"linkedVpcNetwork.includeExportRanges")
+	}
+
 	if d.HasChange("effective_labels") {
 		updateMask = append(updateMask, "labels")
 	}

google/services/networkconnectivity/resource_network_connectivity_spoke_test.go

@@ -665,11 +665,11 @@ resource "google_network_connectivity_spoke" "primary" {
   hub = google_network_connectivity_hub.basic_hub.id
   linked_vpc_network {
     exclude_export_ranges = [
-      "198.51.100.0/24",
+      "198.51.110.0/24",
       "10.10.0.0/16"
     ]
     include_export_ranges = [
-      "198.51.100.0/23", 
+      "198.51.110.0/23", 
       "10.0.0.0/8"
     ]
     uri = google_compute_network.network.self_link