Fix autofilling values in initialize_params.resource_policies causing instance to recreate (#12552) (#20764)

[upstream:78bb3b5df95ac87ff1e82ba4e12624eedd4f951e]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/12552.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: Setting resource policies for `google_compute_instance` outside of terraform or using `google_compute_disk_resource_policy_attachment` will no longer affect the `boot_disk.initialize_params.resource_policies` field
+```

google/services/compute/resource_compute_instance.go

@@ -3078,6 +3078,13 @@ func flattenBootDisk(d *schema.ResourceData, disk *compute.AttachedDisk, config
 	}
 
 	diskDetails, err := getDisk(disk.Source, d, config)
+
+	// Resource policies can get autofilled from the API and on this field and this will cause the instance to recreate
+	// This overrides any value set by the API not to cause a diff when the user didn't set this in their config.
+	if d.Get("boot_disk.0.initialize_params.0.resource_policies.0") == nil || d.Get("boot_disk.0.initialize_params.0.resource_policies") == nil {
+		diskDetails.ResourcePolicies = nil
+	}
+
 	if err != nil {
 		log.Printf("[WARN] Cannot retrieve boot disk details: %s", err)
 

website/docs/r/compute_instance.html.markdown

@@ -305,7 +305,7 @@ is desired, you will need to modify your state file manually using
 
 * `resource_manager_tags` - (Optional) A tag is a key-value pair that can be attached to a Google Cloud resource. You can use tags to conditionally allow or deny policies based on whether a resource has a specific tag. This value is not returned by the API. In Terraform, this value cannot be updated and changing it will recreate the resource.
 
-* `resource_policies` - (Optional) A list of self_links of resource policies to attach to the instance's boot disk. Modifying this list will cause the instance to recreate. Currently a max of 1 resource policy is supported.
+* `resource_policies` - (Optional) A list of self_links of resource policies to attach to the instance's boot disk. Modifying this list will cause the instance to recreate, so any external values are not set until the user specifies this field. Currently a max of 1 resource policy is supported.
 
 * `provisioned_iops` - (Optional) Indicates how many IOPS to provision for the disk.
     This sets the number of I/O operations per second that the disk can handle.