validate helm_release.name in ModifyPlan

Author: jaylonmcshan19-x

helm/resource_helm_release.go

@@ -11,6 +11,7 @@ import (
 	"net/url"
 	"os"
 	pathpkg "path"
+	"regexp"
 	"strings"
 	"time"
 
@@ -1665,6 +1666,8 @@ func checkChartDependencies(ctx context.Context, model *HelmReleaseModel, c *cha
 	return false, diags
 }
 
+var helmReleaseNameRegexp = regexp.MustCompile(`^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`)
+
 func (r *HelmRelease) ModifyPlan(ctx context.Context, req resource.ModifyPlanRequest, resp *resource.ModifyPlanResponse) {
 	if req.Plan.Raw.IsNull() {
 		// resource is being destroyed
@@ -1675,6 +1678,20 @@ func (r *HelmRelease) ModifyPlan(ctx context.Context, req resource.ModifyPlanReq
 	if resp.Diagnostics.HasError() {
 		return
 	}
+	if !plan.Name.IsNull() {
+		name := plan.Name.ValueString()
+		if !helmReleaseNameRegexp.MatchString(name) {
+			resp.Diagnostics.AddError(
+				"Invalid Helm Release Name",
+				fmt.Sprintf(
+					"Release name %q is invalid. Must match regex %s and be no longer than 53 characters.",
+					name,
+					helmReleaseNameRegexp.String(),
+				),
+			)
+			return
+		}
+	}
 	var state *HelmReleaseModel
 	resp.Diagnostics.Append(req.State.Get(ctx, &state)...)
 	if resp.Diagnostics.HasError() {

helm/resource_helm_release_test.go

@@ -823,6 +823,29 @@ func TestAccResourceRelease_createNamespace(t *testing.T) {
 		},
 	})
 }
+func TestAccResourceRelease_invalidReleaseName(t *testing.T) {
+	invalidNames := []string{
+		"invalid_helm_release_name",
+		"ThisHelmRelease",
+	}
+	namespace := createRandomNamespace(t)
+	defer deleteNamespace(t, namespace)
+
+	for index, name := range invalidNames {
+		t.Run(fmt.Sprintf("invalid_name_%d", index), func(t *testing.T) {
+			resource.Test(t, resource.TestCase{
+				ProtoV6ProviderFactories: protoV6ProviderFactories(),
+				Steps: []resource.TestStep{
+					{
+						Config:      testAccHelmReleaseConfigInvalidName(testResourceName, namespace, name),
+						PlanOnly:    true,
+						ExpectError: regexp.MustCompile(`Invalid Helm Release Name`),
+					},
+				},
+			})
+		})
+	}
+}
 
 func TestAccResourceRelease_LocalVersion(t *testing.T) {
 	// NOTE this test confirms that the user is warned if their configured
@@ -894,6 +917,17 @@ func testAccHelmReleaseConfigBasic(resource, ns, name, version string) string {
 	`, resource, name, ns, testRepositoryURL, version)
 }
 
+func testAccHelmReleaseConfigInvalidName(resource, ns, name string) string {
+	return fmt.Sprintf(`
+        resource "helm_release" "%s" {
+            name       = %q
+            namespace  = %q
+            repository = %q
+            chart      = "test-chart"
+        }
+    `, resource, name, ns, testRepositoryURL)
+}
+
 func testAccHelmReleaseConfig_set_wo(resource, ns, name, version string) string {
 	return fmt.Sprintf(`
 		resource "helm_release" "%s" {