Add an acceptance test to cover the fix

Author: fatmcgav

manifest/test/acceptance/strategic_patch_test.go

@@ -0,0 +1,81 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+//go:build acceptance
+// +build acceptance
+
+package acceptance
+
+import (
+	"context"
+	"fmt"
+	"strings"
+	"testing"
+	"time"
+
+	"github.com/hashicorp/go-hclog"
+	"github.com/hashicorp/terraform-provider-kubernetes/manifest/provider"
+)
+
+func TestKubernetesManifest_StrategicPatch(t *testing.T) {
+	ctx := context.Background()
+
+	reattachInfo, err := provider.ServeTest(ctx, hclog.Default(), t)
+	if err != nil {
+		t.Errorf("Failed to create provider instance: %q", err)
+	}
+
+	kind := "Strategic"
+	plural := "strategics"
+	group := "terraform.io"
+	version := "v1"
+	groupVersion := group + "/" + version
+	crd := fmt.Sprintf("%s.%s", plural, group)
+
+	name := strings.ToLower(randName())
+	namespace := "default"
+
+	tfvars := TFVARS{
+		"name":          name,
+		"namespace":     namespace,
+		"kind":          kind,
+		"plural":        plural,
+		"group":         group,
+		"group_version": groupVersion,
+		"cr_version":    version,
+	}
+
+	step1 := tfhelper.RequireNewWorkingDir(ctx, t)
+	step1.SetReattachInfo(ctx, reattachInfo)
+	defer func() {
+		step1.Destroy(ctx)
+		step1.Close()
+		k8shelper.AssertResourceDoesNotExist(t, "apiextensions.k8s.io/v1", "customresourcedefinitions", crd)
+	}()
+
+	crdTfConfig := loadTerraformConfig(t, "StrategicPatch/crd.tf", tfvars)
+	step1.SetConfig(ctx, string(crdTfConfig))
+	step1.Init(ctx)
+	step1.Apply(ctx)
+	k8shelper.AssertResourceExists(t, "apiextensions.k8s.io/v1", "customresourcedefinitions", crd)
+
+	// wait for API to finish ingesting the CRD
+	time.Sleep(5 * time.Second) //lintignore:R018
+
+	reattachInfo2, err := provider.ServeTest(ctx, hclog.Default(), t)
+	if err != nil {
+		t.Errorf("Failed to create additional provider instance: %q", err)
+	}
+	step2 := tfhelper.RequireNewWorkingDir(ctx, t)
+	step2.SetReattachInfo(ctx, reattachInfo2)
+	defer func() {
+		step2.Destroy(ctx)
+		step2.Close()
+		k8shelper.AssertResourceDoesNotExist(t, groupVersion, kind, name)
+	}()
+
+	tfconfig := loadTerraformConfig(t, "StrategicPatch/strategic_patch.tf", tfvars)
+	step2.SetConfig(ctx, string(tfconfig))
+	step2.Init(ctx)
+	step2.Apply(ctx)
+}

manifest/test/acceptance/testdata/StrategicPatch/crd.tf

@@ -0,0 +1,58 @@
+resource "kubernetes_manifest" "crd" {
+  manifest = {
+    apiVersion = "apiextensions.k8s.io/v1"
+    kind       = "CustomResourceDefinition"
+    metadata = {
+      name = "${var.plural}.${var.group}"
+    }
+    spec = {
+      group = "${var.group}"
+      names = {
+        kind   = "${var.kind}"
+        plural = "${var.plural}"
+      }
+      scope = "Namespaced"
+      versions = [
+        {
+          name    = "${var.cr_version}"
+          served  = true
+          storage = true
+          schema = {
+            openAPIV3Schema = {
+              type = "object"
+              properties = {
+                spec = {
+                  type = "object"
+                  properties = {
+                    patchStrategicMerge = {
+                      type = "object"
+                      properties = {
+                        containers = {
+                          type = "array"
+                          "x-kubernetes-list-type" = "map"
+                          "x-kubernetes-list-map-keys" = ["name"]
+                          items = {
+                            type = "object"
+                            required = ["name"]
+                            properties = {
+                              name = {
+                                type = "string"
+                              }
+                              image = {
+                                type = "string"
+                              }
+                            }
+                          }
+                        }
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          }
+        },
+      ]
+    }
+  }
+}

manifest/test/acceptance/testdata/StrategicPatch/strategic_patch.tf

@@ -0,0 +1,20 @@
+resource "kubernetes_manifest" "test" {
+  manifest = {
+    apiVersion = "${var.group_version}"
+    kind       = "${var.kind}"
+    metadata = {
+      name      = "${var.name}"
+      namespace = "${var.namespace}"
+    }
+    spec = {
+      patchStrategicMerge = {
+        containers = [
+          {
+            name  = "nginx"
+            image = "nginx:latest"
+          },
+        ]
+      }
+    }
+  }
+}