Fix crash when SizeLimit is empty on EmptyDirVolumeSource (#983)

Author: jrhouston

kubernetes/structures_pod.go

@@ -412,8 +412,10 @@ func flattenConfigMapVolumeSource(in *v1.ConfigMapVolumeSource) []interface{} {
 
 func flattenEmptyDirVolumeSource(in *v1.EmptyDirVolumeSource) []interface{} {
 	att := make(map[string]interface{})
-	att["medium"] = in.Medium
-	att["size_limit"] = in.SizeLimit.String()
+	att["medium"] = string(in.Medium)
+	if in.SizeLimit != nil {
+		att["size_limit"] = in.SizeLimit.String()
+	}
 	return []interface{}{att}
 }
 

kubernetes/structures_pod_test.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	v1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/resource"
 )
 
 func TestFlattenTolerations(t *testing.T) {
@@ -298,6 +299,54 @@ func TestExpandSecretVolumeSource(t *testing.T) {
 	}
 }
 
+func TestFlattenEmptyDirVolumeSource(t *testing.T) {
+	size, _ := resource.ParseQuantity("64Mi")
+
+	cases := []struct {
+		Input          *v1.EmptyDirVolumeSource
+		ExpectedOutput []interface{}
+	}{
+		{
+			&v1.EmptyDirVolumeSource{
+				Medium: v1.StorageMediumMemory,
+			},
+			[]interface{}{
+				map[string]interface{}{
+					"medium": "Memory",
+				},
+			},
+		},
+		{
+			&v1.EmptyDirVolumeSource{
+				Medium:    v1.StorageMediumMemory,
+				SizeLimit: &size,
+			},
+			[]interface{}{
+				map[string]interface{}{
+					"medium":     "Memory",
+					"size_limit": "64Mi",
+				},
+			},
+		},
+		{
+			&v1.EmptyDirVolumeSource{},
+			[]interface{}{
+				map[string]interface{}{
+					"medium": "",
+				},
+			},
+		},
+	}
+
+	for _, tc := range cases {
+		output := flattenEmptyDirVolumeSource(tc.Input)
+		if !reflect.DeepEqual(output, tc.ExpectedOutput) {
+			t.Fatalf("Unexpected output from flattener.\nExpected: %#v\nGiven:    %#v",
+				tc.ExpectedOutput, output)
+		}
+	}
+}
+
 func TestFlattenConfigMapVolumeSource(t *testing.T) {
 	cases := []struct {
 		Input          *v1.ConfigMapVolumeSource