Skip to content

Commit 2337b28

Browse files
committed
Fix ttl_seconds_after_finished acc test
1 parent 33a6301 commit 2337b28

File tree

1 file changed

+49
-6
lines changed

1 file changed

+49
-6
lines changed

kubernetes/resource_kubernetes_job_test.go

Lines changed: 49 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ func TestAccKubernetesJob_basic(t *testing.T) {
4242
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.parallelism", "2"),
4343
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.template.0.spec.0.container.0.name", "hello"),
4444
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.template.0.spec.0.container.0.image", "alpine"),
45-
46-
skipCheckIf(ttlAfterDisabled,
47-
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.ttl_seconds_after_finished", "10")),
4845
),
4946
},
5047
{
@@ -66,9 +63,31 @@ func TestAccKubernetesJob_basic(t *testing.T) {
6663
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.manual_selector", "true"),
6764
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.template.0.spec.0.container.0.name", "hello"),
6865
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.template.0.spec.0.container.0.image", "alpine"),
66+
),
67+
},
68+
},
69+
})
70+
}
6971

70-
skipCheckIf(ttlAfterDisabled,
71-
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.ttl_seconds_after_finished", "0")),
72+
func TestAccKubernetesJob_ttl_seconds_after_finished(t *testing.T) {
73+
if skip, reason := ttlAfterDisabled(); skip {
74+
t.Skip(reason)
75+
}
76+
77+
var conf api.Job
78+
name := fmt.Sprintf("tf-acc-test-%s", acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum))
79+
80+
resource.Test(t, resource.TestCase{
81+
PreCheck: func() { testAccPreCheck(t) },
82+
IDRefreshName: "kubernetes_job.test",
83+
Providers: testAccProviders,
84+
CheckDestroy: testAccCheckKubernetesJobDestroy,
85+
Steps: []resource.TestStep{
86+
{
87+
Config: testAccKubernetesJobConfig_ttl_seconds_after_finished(name),
88+
Check: resource.ComposeAggregateTestCheckFunc(
89+
testAccCheckKubernetesJobExists("kubernetes_job.test", &conf),
90+
resource.TestCheckResourceAttr("kubernetes_job.test", "spec.0.ttl_seconds_after_finished", "10"),
7291
),
7392
},
7493
},
@@ -137,7 +156,6 @@ resource "kubernetes_job" "test" {
137156
}
138157
spec {
139158
active_deadline_seconds = 120
140-
ttl_seconds_after_finished = 10
141159
backoff_limit = 10
142160
completions = 10
143161
parallelism = 2
@@ -155,6 +173,31 @@ resource "kubernetes_job" "test" {
155173
}`, name)
156174
}
157175

176+
func testAccKubernetesJobConfig_ttl_seconds_after_finished(name string) string {
177+
return fmt.Sprintf(`
178+
resource "kubernetes_job" "test" {
179+
metadata {
180+
name = "%s"
181+
}
182+
spec {
183+
backoff_limit = 10
184+
completions = 10
185+
parallelism = 2
186+
ttl_seconds_after_finished = 10
187+
template {
188+
metadata {}
189+
spec {
190+
container {
191+
name = "hello"
192+
image = "alpine"
193+
command = ["echo", "'hello'"]
194+
}
195+
}
196+
}
197+
}
198+
}`, name)
199+
}
200+
158201
func testAccKubernetesJobConfig_modified(name string) string {
159202
return fmt.Sprintf(`
160203
resource "kubernetes_job" "test" {

0 commit comments

Comments
 (0)