fix: Resolve panic with ElementKeyInt(0): can't use tftypes

This commit updates the `manifest/morph/scaffold.go` logic in order to
resolve a panic encountered when working with `Tuple` types.

Also adds a new unit test to cover this case.

Disclaimer: This fix and the coresponding test case was generated by
Gemini, and has been reviewed and tested by myself.

Fixes: #2778 #2754 plus probably others...

Author: Gavin Williams

manifest/morph/scaffold.go

@@ -75,15 +75,17 @@ func DeepUnknown(t tftypes.Type, v tftypes.Value, p *tftypes.AttributePath) (tft
 		if err != nil {
 			return tftypes.Value{}, p.NewError(err)
 		}
+		ntypes := make([]tftypes.Type, len(atts))
 		for i, et := range atts {
 			np := p.WithElementKeyInt(i)
 			nv, err := DeepUnknown(et, vals[i], np)
 			if err != nil {
 				return tftypes.Value{}, np.NewError(err)
 			}
 			vals[i] = nv
+			ntypes[i] = nv.Type()
 		}
-		return tftypes.NewValue(tftypes.Tuple{ElementTypes: atts}, vals), nil
+		return tftypes.NewValue(tftypes.Tuple{ElementTypes: ntypes}, vals), nil
 	case t.Is(tftypes.List{}) || t.Is(tftypes.Set{}):
 		if v.IsNull() {
 			return tftypes.NewValue(t, tftypes.UnknownValue), nil

manifest/morph/scaffold_test.go

@@ -299,6 +299,61 @@ func TestDeepUnknown(t *testing.T) {
 				},
 			),
 		},
+		"tuple-with-dynamic": {
+			In: deepUnknownTestSampleInput{
+				T: tftypes.Tuple{
+					ElementTypes: []tftypes.Type{
+						tftypes.DynamicPseudoType,
+					},
+				},
+				V: tftypes.NewValue(
+					tftypes.Tuple{
+						ElementTypes: []tftypes.Type{
+							tftypes.Object{
+								AttributeTypes: map[string]tftypes.Type{
+									"name": tftypes.String,
+								},
+							},
+						},
+					},
+					[]tftypes.Value{
+						tftypes.NewValue(
+							tftypes.Object{
+								AttributeTypes: map[string]tftypes.Type{
+									"name": tftypes.String,
+								},
+							},
+							map[string]tftypes.Value{
+								"name": tftypes.NewValue(tftypes.String, "test"),
+							},
+						),
+					},
+				),
+			},
+			Out: tftypes.NewValue(
+				tftypes.Tuple{
+					ElementTypes: []tftypes.Type{
+						tftypes.Object{
+							AttributeTypes: map[string]tftypes.Type{
+								"name": tftypes.String,
+							},
+						},
+					},
+				},
+				[]tftypes.Value{
+					tftypes.NewValue(
+						tftypes.Object{
+							AttributeTypes: map[string]tftypes.Type{
+								"name": tftypes.String,
+							},
+						},
+						map[string]tftypes.Value{
+							"name": tftypes.NewValue(tftypes.String, "test"),
+						},
+					),
+				},
+			),
+		},
 	}
 	for n, s := range samples {
 		t.Run(n, func(t *testing.T) {