Skip to content

Commit 316bc4e

Browse files
authored
Refine issue assigner in issue-opened.yml (#2526)
* add review-assigner.yaml * test with mau * try to get issue assigner working again * test * second try * assign with the pd stuff * comment out pagerduty * comment out * use code when it last worked * copy and paste * add pagerduty * let reviewer * test assigning to sheneska * test with alexsomesan * test using map get - final * add into issue-opened.yaml * set to sheneska * fix gha logic * typo * use reviewerGH * better error
1 parent bb46733 commit 316bc4e

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

.github/workflows/issue-opened.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ jobs:
2727
const { PAGERDUTY_TOKEN } = process.env
2828
const { api } = require('@pagerduty/pdjs');
2929
const pd = api({token: PAGERDUTY_TOKEN});
30-
let reviewer = ""
3130
const reviewerList = new Map([
3231
["Sheneska Williams", "sheneska"],
3332
["Mauricio Alvarez Leon", "BBBmau"],
@@ -37,19 +36,20 @@ jobs:
3736
["Aleksandr Rybolovlev", "arybolovlev"],
3837
]);
3938
40-
pd.get('oncalls?escalation_policy_ids%5B%5D=PH8IF3M')
41-
.then(({data}) => {
42-
reviewer = reviewerList.get(data.oncalls[0].user.summary)
43-
console.log("Assigning issue to " + reviewer);
44-
}).catch(console.error)
39+
let resp = await pd.get('oncalls?escalation_policy_ids%5B%5D=PH8IF3M')
40+
if (resp.status != 200){
41+
core.setFailed("PagerDuty Error: " + resp.statusText)
42+
}
43+
const reviewer = resp.data.oncalls[0].user.summary
44+
const reviewerGH = reviewerList.get(reviewer)
45+
console.log("Assigning issue to " + reviewerGH);
4546
46-
try{
47-
await github.rest.issues.addAssignees({
47+
resp = await github.rest.issues.addAssignees({
4848
owner: context.repo.owner,
4949
repo: context.repo.repo,
50-
assignees: reviewer,
50+
assignees: reviewerGH,
5151
issue_number: context.issue.number,
52-
})
53-
} catch(error){
54-
core.setFailed("error assigning reviewer: " + error)
52+
})
53+
if (resp.status != 200){
54+
core.setFailed("error assigning reviewer: user doesn't have the appropriate permissions to be assigned an issue.")
5555
}

0 commit comments

Comments
 (0)