Skip to content

Commit 69263f8

Browse files
authored
remove mention of doc generation use (#2605)
1 parent 01f6171 commit 69263f8

File tree

2 files changed

+55
-53
lines changed

2 files changed

+55
-53
lines changed
Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,42 @@
1-
name: "Documentation Updates"
1+
# name: "Documentation Updates"
22

3-
on:
4-
pull_request:
5-
paths:
6-
- 'docs/**'
7-
types: [opened, synchronize, labeled]
3+
# on:
4+
# pull_request:
5+
# paths:
6+
# - 'docs/**'
7+
# types: [opened, synchronize, labeled]
88

9-
push:
10-
branches:
11-
- main
9+
# push:
10+
# branches:
11+
# - main
1212

13-
jobs:
14-
check-docs:
15-
runs-on: ubuntu-latest
13+
# jobs:
14+
# check-docs:
15+
# runs-on: ubuntu-latest
1616

17-
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-documentation') }}
17+
# if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-documentation') }}
1818

19-
steps:
20-
- name: Checkout repository
21-
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
19+
# steps:
20+
# - name: Checkout repository
21+
# uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
2222

23-
- name: Set up Go
24-
uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
25-
with:
26-
go-version-file: 'go.mod'
23+
# - name: Set up Go
24+
# uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
25+
# with:
26+
# go-version-file: 'go.mod'
2727

28-
- name: Install tfplugindocs command
29-
run: go install github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs@latest
28+
# - name: Install tfplugindocs command
29+
# run: go install github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs@latest
3030

31-
- name: Run tfplugindocs command
32-
run: tfplugindocs generate
31+
# - name: Run tfplugindocs command
32+
# run: tfplugindocs generate
3333

34-
- name: Check for changes
35-
run: |
36-
git diff --exit-code
34+
# - name: Check for changes
35+
# run: |
36+
# git diff --exit-code
3737

38-
- name: Undocumented changes
39-
run: |
40-
echo 'Documentation is not up to date. Please refer to the `Making Changes` in the Contribution Guide on how to properly update documentation.'
41-
exit 1
42-
if: failure()
38+
# - name: Undocumented changes
39+
# run: |
40+
# echo 'Documentation is not up to date. Please refer to the `Making Changes` in the Contribution Guide on how to properly update documentation.'
41+
# exit 1
42+
# if: failure()

_about/CONTRIBUTING.md

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ If you want to learn more about developing a Terraform provider, please refer to
1010

1111
[Install](https://go.dev/doc/install) the version of Golang as indicated in the [go.mod](../go.mod) file.
1212

13-
1. Fork this repo
13+
2. Fork this repo
1414

1515
[Fork](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo) the provider repository and clone it on your computer.
1616

@@ -23,7 +23,7 @@ If you want to learn more about developing a Terraform provider, please refer to
2323

2424
From now on, we are going to assume that you have a copy of the repository on your computer and work within the `terraform-provider-kubernetes` directory.
2525

26-
1. Prepare a Kubernetes Cluster
26+
3. Prepare a Kubernetes Cluster
2727

2828
While our preference is to use [KinD](https://kind.sigs.k8s.io/) for setting up a Kubernetes cluster for development and test purposes, feel free to opt for the solution that best suits your preferences. Please bear in mind that some acceptance tests might require specific cluster settings, which we maintain in the KinD [configuration file](../.github/config/acceptance_tests_kind_config.yaml).
2929

@@ -55,30 +55,32 @@ If you want to learn more about developing a Terraform provider, please refer to
5555
This quick guide covers best practices for adding a new Resource.
5656

5757
1. Ensure all dependncies are installed.
58-
1. Add an SDK Client.
59-
1. Add Resource Schema and define attributes [see Kubernetes Documentation](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs). A best and recommended practice is reuse constants from the Kuberentes packages as a default value in an attribute or within a validation function.
60-
1. Scaffold an empty/new resource.
61-
1. Add Acceptance Tests(s) for the resource.
62-
1. Run Acceptance Tests(s) for this resource.
63-
1. Add Documentation for this resource by editing the `.md.tmpl` file to include the appropriate [Data Fields](https://pkg.go.dev/text/template) and executing `tfplugindocs generate` command [see Terraform PluginDocs](https://github.com/hashicorp/terraform-plugin-docs#data-fields) then inspecting the corresponding `.md` file in the `/docs` to see all changes. The Data Fields that are currently apart of the templates are those for the Schema ({{ .SchemaMarkdown }}), Name ({{ .Name }}) and ({{ .Description }}).
64-
1. Execute `make docs-lint` and `make tests-lint` commands
65-
1. Create a Pull Request for your changes.
58+
2. Add an SDK Client.
59+
3. Add Resource Schema and define attributes [see Kubernetes Documentation](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs). A best and recommended practice is reuse constants from the Kuberentes packages as a default value in an attribute or within a validation function.
60+
4. Scaffold an empty/new resource.
61+
5. Add Acceptance Tests(s) for the resource.
62+
6. Run Acceptance Tests(s) for this resource.
63+
7. Add documentation for this resource in the appropriate `docs/resources/<TYPE>_<VERSION>.go.md` file.
64+
<!-- 7. Add Documentation for this resource by editing the `.md.tmpl` file to include the appropriate [Data Fields](https://pkg.go.dev/text/template) and executing `tfplugindocs generate` command [see Terraform PluginDocs](https://github.com/hashicorp/terraform-plugin-docs#data-fields) then inspecting the corresponding `.md` file in the `/docs` to see all changes. The Data Fields that are currently apart of the templates are those for the Schema ({{ .SchemaMarkdown }}), Name ({{ .Name }}) and ({{ .Description }}). -->
65+
8. Execute `make docs-lint` and `make tests-lint` commands
66+
9. Create a Pull Request for your changes.
6667

6768
### Adding a New Data Source
6869

6970
1. Ensure all dependncies are installed.
70-
1. Add an SDK Client.
71-
1. Add Data Source Schema and define attributes [see Kubernetes Documentation](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs).
71+
2. Add an SDK Client.
72+
3. Add Data Source Schema and define attributes [see Kubernetes Documentation](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs).
7273
A best and recommended practice is reuse constants from the Kuberentes packages as a default value in an attribute or within a validation function.
73-
1. Scaffold an empty/new resource.
74-
1. Add Acceptance Tests(s) for the data source.
75-
1. Run Acceptance Tests(s) for this data source.
76-
1. Add Documentation for this data source by editing the `.md.tmpl` file to include the appropriate [Data Fields](https://pkg.go.dev/text/template) and executing `tfplugindocs generate` command [see Terraform PluginDocs](https://github.com/hashicorp/terraform-plugin-docs#data-fields) then inspecting the corresponding `.md` file in the `/docs` to see all changes. The Data Fields that are currently apart of the templates are those for the Schema ({{ .SchemaMarkdown }}), Name ({{ .Name }}) and ({{ .Description }}).
77-
1. Execute `make docs-lint` and `make tests-lint` commands
78-
1. Create a Pull Request for your changes.
79-
80-
### Adding/Editing Documentation
81-
All Documentation is edited in the `.md.tmpl` file. Please note that the `tfplugindocs generate` command should be executed to ensure it is updated and reflected in the `.md` files.
74+
4. Scaffold an empty/new resource.
75+
5. Add Acceptance Tests(s) for the data source.
76+
6. Run Acceptance Tests(s) for this data source.
77+
7. Add documentation for this data source in the appropriate `docs/data-sources/<TYPE>_<VERSION>.md` file.
78+
<!-- 7. Add Documentation for this data source by editing the `.md.tmpl` file to include the appropriate [Data Fields](https://pkg.go.dev/text/template) and executing `tfplugindocs generate` command [see Terraform PluginDocs](https://github.com/hashicorp/terraform-plugin-docs#data-fields) then inspecting the corresponding `.md` file in the `/docs` to see all changes. The Data Fields that are currently apart of the templates are those for the Schema ({{ .SchemaMarkdown }}), Name ({{ .Name }}) and ({{ .Description }}). -->
79+
8. Execute `make docs-lint` and `make tests-lint` commands
80+
9. Create a Pull Request for your changes.
81+
82+
<!-- ### Adding/Editing Documentation
83+
All Documentation is edited in the `.md.tmpl` file. Please note that the `tfplugindocs generate` command should be executed to ensure it is updated and reflected in the `.md` files. -->
8284

8385
## Testing
8486

0 commit comments

Comments
 (0)