kubernetes_service: cluster_ip should support None (#1292)

* cluster_ip for service should support None

* Update CHANGELOG for v2.3.1

Author: jrhouston

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.3.1 (Unreleased)
+
+BUG FIXES:
+* `cluster_ip` for `kubernetes_service` should support value `None` (#1291)
+
 ## 2.3.0 (June 02, 2021)
 
 BUG FIXES:

kubernetes/resource_kubernetes_service.go

@@ -53,12 +53,15 @@ func resourceKubernetesServiceSchemaV1() map[string]*schema.Schema {
 			Elem: &schema.Resource{
 				Schema: map[string]*schema.Schema{
 					"cluster_ip": {
-						Type:         schema.TypeString,
-						Description:  "The IP address of the service. It is usually assigned randomly by the master. If an address is specified manually and is not in use by others, it will be allocated to the service; otherwise, creation of the service will fail. `None` can be specified for headless services when proxying is not required. Ignored if type is `ExternalName`. More info: http://kubernetes.io/docs/user-guide/services#virtual-ips-and-service-proxies",
-						Optional:     true,
-						ForceNew:     true,
-						Computed:     true,
-						ValidateFunc: validation.IsIPAddress,
+						Type:        schema.TypeString,
+						Description: "The IP address of the service. It is usually assigned randomly by the master. If an address is specified manually and is not in use by others, it will be allocated to the service; otherwise, creation of the service will fail. `None` can be specified for headless services when proxying is not required. Ignored if type is `ExternalName`. More info: http://kubernetes.io/docs/user-guide/services#virtual-ips-and-service-proxies",
+						Optional:    true,
+						ForceNew:    true,
+						Computed:    true,
+						ValidateFunc: validation.Any(
+							validation.StringInSlice([]string{api.ClusterIPNone}, false),
+							validation.IsIPAddress,
+						),
 					},
 					"external_ips": {
 						Type:        schema.TypeSet,

kubernetes/resource_kubernetes_service_test.go

@@ -247,6 +247,28 @@ func TestAccKubernetesService_loadBalancer_healthcheck(t *testing.T) {
 	})
 }
 
+func TestAccKubernetesService_headless(t *testing.T) {
+	var conf api.Service
+	name := acctest.RandomWithPrefix("tf-acc-test")
+	resourceName := "kubernetes_service.test"
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		IDRefreshName:     resourceName,
+		ProviderFactories: testAccProviderFactories,
+		CheckDestroy:      testAccCheckKubernetesServiceDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccKubernetesServiceConfig_headless(name),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					testAccCheckKubernetesServiceExists(resourceName, &conf),
+					resource.TestCheckResourceAttr(resourceName, "spec.0.cluster_ip", "None"),
+				),
+			},
+		},
+	})
+}
+
 func TestAccKubernetesService_loadBalancer_annotations_aws(t *testing.T) {
 	var conf api.Service
 	name := acctest.RandomWithPrefix("tf-acc-test")
@@ -1078,6 +1100,25 @@ func testAccKubernetesServiceConfig_loadBalancer_annotations_aws_modified(name s
 `, name)
 }
 
+func testAccKubernetesServiceConfig_headless(name string) string {
+	return fmt.Sprintf(`resource "kubernetes_service" "test" {
+  metadata {
+    name = "%s"
+  }
+  spec {
+    cluster_ip = "None"
+    selector   = {
+      App = "MyApp"
+    }
+    port {
+      port        = 8888
+      target_port = 80
+    }
+  }
+}
+`, name)
+}
+
 func testAccKubernetesServiceConfig_loadBalancer_healthcheck(name string, nodePort int) string {
 	return fmt.Sprintf(`resource "kubernetes_service" "test" {
   metadata {