Code review suggestions

Author: alexsomesan

manifest/provider/import_test.go

@@ -41,24 +41,24 @@ func TestParseImportID(t *testing.T) {
 			Err: fmt.Errorf("invalid format for import ID [%s]\nExpected format is: apiVersion=<value>,kind=<value>,name=<value>[,namespace=<value>]", "foobar"),
 		},
 	}
-	for _, s := range samples {
-		gotGvk, gotName, gotNamespace, gotErr := parseImportID(s.ID)
-		if gotErr != nil {
-			if gotErr.Error() == s.Err.Error() {
+	for _, expected := range samples {
+		actualGvk, actualName, actualNamespace, actualErr := parseImportID(expected.ID)
+		if actualErr != nil {
+			if actualErr.Error() == expected.Err.Error() {
 				continue
 			}
-			t.Fatal(gotErr.Error())
+			t.Fatal(actualErr.Error())
 		}
-		if s.GVK != gotGvk {
-			t.Log("GVK (got / wanted):", gotGvk, s.GVK)
+		if expected.GVK != actualGvk {
+			t.Log("GVK (actual / wanted):", actualGvk, expected.GVK)
 			t.Fail()
 		}
-		if s.Name != gotName {
-			t.Log("Name (got / wanted):", gotName, s.Name)
+		if expected.Name != actualName {
+			t.Log("Name (actual / wanted):", actualName, expected.Name)
 			t.Fail()
 		}
-		if s.Namespace != gotNamespace {
-			t.Log("Namespace (got / wanted):", gotNamespace, s.Namespace)
+		if expected.Namespace != actualNamespace {
+			t.Log("Namespace (actual / wanted):", actualNamespace, expected.Namespace)
 			t.Fail()
 		}
 	}

manifest/test/helper/kubernetes/kubernetes_helper.go

@@ -1,3 +1,4 @@
+//go:build acceptance
 // +build acceptance
 
 package kubernetes
@@ -81,7 +82,7 @@ func (k *Helper) CreateNamespace(t *testing.T, name string) {
 	}
 }
 
-// CreateNamespace creates a new namespace
+// CreateConfigMap creates a new ConfigMap
 func (k *Helper) CreateConfigMap(t *testing.T, name string, namespace string, data map[string]interface{}) {
 	t.Helper()
 
@@ -103,7 +104,7 @@ func (k *Helper) CreateConfigMap(t *testing.T, name string, namespace string, da
 	}
 }
 
-// DeleteResource deletes a namespace
+// DeleteResource deletes a resource referred to by the name and GVK
 func (k *Helper) DeleteResource(t *testing.T, name string, gvr schema.GroupVersionResource) {
 	t.Helper()
 
@@ -113,7 +114,7 @@ func (k *Helper) DeleteResource(t *testing.T, name string, gvr schema.GroupVersi
 	}
 }
 
-// DeleteResource deletes a namespace
+// DeleteResource deletes a namespaced resource referred to by the name and GVK
 func (k *Helper) DeleteNamespacedResource(t *testing.T, name string, namespace string, gvr schema.GroupVersionResource) {
 	t.Helper()
 

website/docs/r/manifest.html.markdown

@@ -111,7 +111,7 @@ kubectl get secrets sample -o yaml | tfk8s --strip -o sample.tf
 ### Import the resource state from the cluster
 
 ```
-terraform import kubernetes_manifest.secret_sample "v1#Secret#default#sample"
+terraform import kubernetes_manifest.secret_sample "apiVersion=v1,kind=Secret,namespace=default,name=sample"
 ```
 
 Note the import ID as the last argument to the import command. This ID points Terraform at which Kubernetes object to read when importing.