kubernetes_manifest: fix waiter crash when conditions are not present (#2008)

Author: jrhouston

.changelog/2008.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+kubernetes_manifest: fix crash when waiting on conditions that are not yet present
+```

manifest/provider/waiter.go

@@ -343,7 +343,7 @@ func (w *ConditionsWaiter) Wait(ctx context.Context) error {
 		}
 
 		if status, ok := res.Object["status"].(map[string]interface{}); ok {
-			if conditions := status["conditions"].([]interface{}); ok && len(conditions) > 0 {
+			if conditions, ok := status["conditions"].([]interface{}); ok && len(conditions) > 0 {
 				conditionsMet := true
 				for _, c := range w.conditions {
 					var condition map[string]tftypes.Value

manifest/test/acceptance/testdata/Wait/wait_for_condition_invalid.tf

@@ -0,0 +1,21 @@
+resource "kubernetes_manifest" "test" {
+  manifest = {
+    apiVersion = "v1"
+    kind       = "Namespace"
+
+    metadata = {
+      name      = var.name
+    }
+  }
+
+  wait {
+    condition {
+      type = "Ready"
+      status = "True"
+    }
+  }
+
+  timeouts {
+    create = "3s"
+  }
+}

manifest/test/acceptance/wait_test.go

@@ -5,6 +5,7 @@ package acceptance
 
 import (
 	"context"
+	"strings"
 	"testing"
 	"time"
 
@@ -185,3 +186,37 @@ func TestKubernetesManifest_WaitCondition_Pod(t *testing.T) {
 		"kubernetes_manifest.test.wait.0.condition.1.status": "True",
 	})
 }
+
+func TestKubernetesManifest_Wait_InvalidCondition(t *testing.T) {
+	// NOTE: this tests that specifying a condition for a resource that
+	// will never have one does not crash the provider
+
+	ctx := context.Background()
+
+	name := randName()
+
+	reattachInfo, err := provider.ServeTest(ctx, hclog.Default(), t)
+	if err != nil {
+		t.Errorf("Failed to create provider instance: %q", err)
+	}
+
+	tf := tfhelper.RequireNewWorkingDir(ctx, t)
+	tf.SetReattachInfo(ctx, reattachInfo)
+	defer func() {
+		tf.Destroy(ctx)
+		tf.Close()
+		k8shelper.AssertResourceDoesNotExist(t, "v1", "namespaces", name)
+	}()
+
+	tfvars := TFVARS{
+		"name": name,
+	}
+	tfconfig := loadTerraformConfig(t, "Wait/wait_for_condition_invalid.tf", tfvars)
+	tf.SetConfig(ctx, tfconfig)
+	tf.Init(ctx)
+
+	err = tf.Apply(ctx)
+	if err == nil || !strings.Contains(err.Error(), "Terraform timed out waiting on the operation to complete") {
+		t.Fatalf("Waiter should have timed out")
+	}
+}