Fix conversion of big.Float to float64 in kubernetes_manifest (#1661)

* big.Float to float64 conversion accuracy indicator is not an error
* More precise testing of float handling in manifest

Author: alexsomesan

.github/workflows/check_examples.yaml

@@ -20,7 +20,8 @@ jobs:
         terraform_version:
           - "0.14.10"
           - "0.15.5"
-          - "1.0.6"
+          - "1.0.11"
+          - "1.1.7"
     env:
       TF_X_KUBERNETES_MANIFEST_RESOURCE: 1
       KUBE_CONFIG_PATH: "~/.kube/config"

.github/workflows/manifest_acc.yaml

@@ -23,7 +23,8 @@ jobs:
           # and there is no image available for the latest v1.19.x
           # - v1.19.11@sha256:07db187ae84b4b7de440a73886f008cf903fcf5764ba8106a9fd5243d6f32729
         terraform_version:
-          - 1.0.8
+          - 1.1.7
+          - 1.0.11
           - 0.15.5
           - 0.14.11
     steps:

manifest/payload/from_value.go

@@ -38,10 +38,7 @@ func FromTFValue(in tftypes.Value, th map[string]string, ap *tftypes.AttributePa
 			}
 			return inv, nil
 		}
-		fnv, acc := nv.Float64()
-		if acc != big.Exact {
-			return nil, ap.NewErrorf("[%s] inexact float approximation when converting number value", ap.String())
-		}
+		fnv, _ := nv.Float64()
 		return fnv, err
 	case in.Type().Is(tftypes.String):
 		var sv string

manifest/payload/from_value_test.go

@@ -9,6 +9,11 @@ import (
 )
 
 func TestFromTFValue(t *testing.T) {
+	// this mimics how terraform-plugin-go decodes floats that terraform sends over msgpack without a precision marker
+	fv, _, err := big.ParseFloat("98.765", 10, 512, big.ToNearestEven)
+	if err != nil {
+		t.Fatalf("cannot create test float value out of string: %s", err)
+	}
 	samples := map[string]struct {
 		In  tftypes.Value
 		Th  map[string]string
@@ -18,9 +23,13 @@ func TestFromTFValue(t *testing.T) {
 			In:  tftypes.NewValue(tftypes.String, "hello"),
 			Out: "hello",
 		},
-		"float-primitive": {
-			In:  tftypes.NewValue(tftypes.Number, big.NewFloat(100.2)),
-			Out: 100.2,
+		"float-primitive-native-big": {
+			In:  tftypes.NewValue(tftypes.Number, big.NewFloat(98.765)),
+			Out: float64(98.765),
+		},
+		"float-primitive-from-string": {
+			In:  tftypes.NewValue(tftypes.Number, fv),
+			Out: float64(98.765),
 		},
 		"boolean-primitive": {
 			In:  tftypes.NewValue(tftypes.Bool, true),

manifest/test/acceptance/customresource_test.go

@@ -5,6 +5,7 @@ package acceptance
 
 import (
 	"context"
+	"encoding/json"
 	"fmt"
 	"strings"
 	"testing"
@@ -86,6 +87,7 @@ func TestKubernetesManifest_CustomResource(t *testing.T) {
 		"kubernetes_manifest.test.object.metadata.name":      name,
 		"kubernetes_manifest.test.object.metadata.namespace": namespace,
 		"kubernetes_manifest.test.object.data":               "this is a test",
+		"kubernetes_manifest.test.object.refs":               json.Number("98.765"),
 		"kubernetes_manifest.test.object.stuff.0":            map[string]interface{}{"foo": interface{}(nil)},
 		"kubernetes_manifest.test.object.limits": map[string]interface{}{
 			"foo": interface{}("bar"),

manifest/test/acceptance/testdata/CustomResource/custom_resource.tf

@@ -9,6 +9,7 @@ resource "kubernetes_manifest" "test" {
       name      = var.name
     }
     data = "this is a test"
+    refs = 98.765
     stuff = [
       {
         foo = null