Make more resource delete operations idempotent (#1919)

Author: sheneska

.changelog/1919.txt

@@ -0,0 +1,15 @@
+```release-note:enhancement
+Add additional validation on the delete operation to make it idempotent. That affects the following resources:
+  - kubernetes_priority_class
+  - kubernetes_replication_controller
+  - kubernetes_resource_quota
+  - kubernetes_role
+  - kubernetes_role_binding
+  - kubernetes_secret
+  - kubernetes_service
+  - kubernetes_service_account
+  - kubernetes_stateful_set
+  - kubernetes_storage_class
+  - kubernetes_validating_webhook_configuration
+  - kubernetes_validating_webhook_configuration_v1
+```

kubernetes/resource_kubernetes_priority_class.go

@@ -203,6 +203,9 @@ func resourceKubernetesPriorityClassDelete(ctx context.Context, d *schema.Resour
 	log.Printf("[INFO] Deleting priority class: %#v", name)
 	err = conn.SchedulingV1().PriorityClasses().Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 

kubernetes/resource_kubernetes_replication_controller.go

@@ -276,6 +276,9 @@ func resourceKubernetesReplicationControllerDelete(ctx context.Context, d *schem
 
 	err = conn.CoreV1().ReplicationControllers(namespace).Delete(ctx, name, deleteOptions)
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 

kubernetes/resource_kubernetes_resource_quota.go

@@ -265,6 +265,9 @@ func resourceKubernetesResourceQuotaDelete(ctx context.Context, d *schema.Resour
 	log.Printf("[INFO] Deleting resource quota: %#v", name)
 	err = conn.CoreV1().ResourceQuotas(namespace).Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 

kubernetes/resource_kubernetes_role.go

@@ -181,6 +181,9 @@ func resourceKubernetesRoleDelete(ctx context.Context, d *schema.ResourceData, m
 	log.Printf("[INFO] Deleting role: %#v", name)
 	err = conn.RbacV1().Roles(namespace).Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 

kubernetes/resource_kubernetes_role_binding.go

@@ -166,6 +166,9 @@ func resourceKubernetesRoleBindingDelete(ctx context.Context, d *schema.Resource
 	log.Printf("[INFO] Deleting RoleBinding: %#v", name)
 	err = conn.RbacV1().RoleBindings(namespace).Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 	log.Printf("[INFO] RoleBinding %s deleted", name)

kubernetes/resource_kubernetes_secret.go

@@ -300,6 +300,9 @@ func resourceKubernetesSecretDelete(ctx context.Context, d *schema.ResourceData,
 	log.Printf("[INFO] Deleting secret: %q", name)
 	err = conn.CoreV1().Secrets(namespace).Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 

kubernetes/resource_kubernetes_service.go

@@ -481,6 +481,9 @@ func resourceKubernetesServiceDelete(ctx context.Context, d *schema.ResourceData
 	log.Printf("[INFO] Deleting service: %#v", name)
 	err = conn.CoreV1().Services(namespace).Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 

kubernetes/resource_kubernetes_service_account.go

@@ -397,6 +397,9 @@ func resourceKubernetesServiceAccountDelete(ctx context.Context, d *schema.Resou
 	log.Printf("[INFO] Deleting service account: %#v", name)
 	err = conn.CoreV1().ServiceAccounts(namespace).Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 

kubernetes/resource_kubernetes_stateful_set.go

@@ -239,6 +239,9 @@ func resourceKubernetesStatefulSetDelete(ctx context.Context, d *schema.Resource
 	log.Printf("[INFO] Deleting StatefulSet: %#v", name)
 	err = conn.AppsV1().StatefulSets(namespace).Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {
+		if statusErr, ok := err.(*errors.StatusError); ok && errors.IsNotFound(statusErr) {
+			return nil
+		}
 		return diag.FromErr(err)
 	}
 	err = resource.RetryContext(ctx, d.Timeout(schema.TimeoutDelete), func() *resource.RetryError {