Fix crash in manifest when configuration contains DynamicPseudotyped unknown values. (#2055)

alexsomesan · web-flow · commit a4e09ba8e792 · 2023-03-21T20:18:47.000+01:00
Generate unknown value of the type required by schema, when backfilling unset values during planning.
diff --git a/.changelog/2055.txt b/.changelog/2055.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+`resource/kubernetes_manifest`: Fix crash when manifest config contains unknown values of unknown type (DynamicPseudoType)
+```
diff --git a/manifest/morph/scaffold.go b/manifest/morph/scaffold.go
@@ -16,7 +16,7 @@ func DeepUnknown(t tftypes.Type, v tftypes.Value, p *tftypes.AttributePath) (tft
 		return tftypes.Value{}, fmt.Errorf("type cannot be nil")
 	}
 	if !v.IsKnown() {
-		return v, nil
+		return tftypes.NewValue(t, tftypes.UnknownValue), nil
 	}
 	switch {
 	case t.Is(tftypes.Object{}):

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:bug
	`2`	+`resource/kubernetes_manifest`: Fix crash when manifest config contains unknown values of unknown type (DynamicPseudoType)
	`3`	+```
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ func DeepUnknown(t tftypes.Type, v tftypes.Value, p *tftypes.AttributePath) (tft`
`16`	`16`	`return tftypes.Value{}, fmt.Errorf("type cannot be nil")`
`17`	`17`	`}`
`18`	`18`	`if !v.IsKnown() {`
`19`		`- return v, nil`
	`19`	`+ return tftypes.NewValue(t, tftypes.UnknownValue), nil`
`20`	`20`	`}`
`21`	`21`	`switch {`
`22`	`22`	`case t.Is(tftypes.Object{}):`