clarify and simplify the data source tests

Author: dak1n1

kubernetes/data_source_kubernetes_config_map_test.go

@@ -8,6 +8,8 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
+// TestAccKubernetesDataSourceConfigMap_basic tests that the data source is able to read
+// plaintext data, binary data, annotation, label, and name of the config map resource.
 func TestAccKubernetesDataSourceConfigMap_basic(t *testing.T) {
 	name := fmt.Sprintf("tf-acc-test-%s", acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum))
 
@@ -19,31 +21,45 @@ func TestAccKubernetesDataSourceConfigMap_basic(t *testing.T) {
 				Config: testAccKubernetesDataSourceConfigMapConfig_basic(name),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "metadata.0.name", name),
-					resource.TestCheckResourceAttrSet("data.kubernetes_config_map.test", "metadata.0.generation"),
-					resource.TestCheckResourceAttrSet("data.kubernetes_config_map.test", "metadata.0.resource_version"),
-					resource.TestCheckResourceAttrSet("data.kubernetes_config_map.test", "metadata.0.self_link"),
-					resource.TestCheckResourceAttrSet("data.kubernetes_config_map.test", "metadata.0.uid"),
-					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "metadata.0.annotations.%", "2"),
 					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "metadata.0.annotations.TestAnnotationOne", "one"),
-					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "metadata.0.annotations.TestAnnotationTwo", "two"),
 					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "metadata.0.labels.TestLabelOne", "one"),
-					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "metadata.0.labels.TestLabelTwo", "two"),
-					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "metadata.0.labels.TestLabelThree", "three"),
-					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "data.%", "2"),
 					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "data.one", "first"),
-					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "data.two", "second"),
+					resource.TestCheckResourceAttr("data.kubernetes_config_map.test", "binary_data.raw", "UmF3IGRhdGEgc2hvdWxkIGNvbWUgYmFjayBhcyBpcyBpbiB0aGUgcG9k"),
 				),
 			},
 		},
 	})
 }
 
+// testAccKubernetesDataSourceConfigMapConfig_basic provides the terraform config
+// used to test basic functionality of the config_map data source.
 func testAccKubernetesDataSourceConfigMapConfig_basic(name string) string {
-	return testAccKubernetesConfigMapConfig_basic(name) + `
+	return fmt.Sprintf(`
+resource "kubernetes_config_map" "test" {
+  metadata {
+    annotations = {
+      TestAnnotationOne = "one"
+    }
+
+    labels = {
+      TestLabelOne   = "one"
+    }
+
+    name = "%s"
+  }
+
+  data = {
+    one = "first"
+  }
+
+  binary_data = {
+    raw = "${base64encode("Raw data should come back as is in the pod")}"
+  }
+}
+
 data "kubernetes_config_map" "test" {
 	metadata {
 		name = "${kubernetes_config_map.test.metadata.0.name}"
 	}
-}
-`
+  }`, name)
 }