Merge pull request #1439 from hashicorp/TF-15053-terraform-provider-tfe-gh-issue-1341-tfe-team-visibility-not-being-set-as-defined

Remove 'secret' default from `tfe_team` because it requires explicit or owner access

Author: brandonc

CHANGELOG.md

@@ -1,3 +1,9 @@
+## Unreleased
+
+## BREAKING CHANGES
+
+* `r/tfe_team`: Default "secret" visibility has been removed from tfe_team because it now requires explicit or owner access. The default, "organization", is now computed by the platform. by @brandonc [#1439](https://github.com/hashicorp/terraform-provider-tfe/pull/1439)
+
 ## v0.58.0
 
 ENHANCEMENTS:

internal/provider/resource_tfe_team.go

@@ -131,7 +131,7 @@ func resourceTFETeam() *schema.Resource {
 			"visibility": {
 				Type:     schema.TypeString,
 				Optional: true,
-				Default:  "secret",
+				Computed: true,
 				ValidateFunc: validation.StringInSlice([]string{
 					"secret",
 					"organization",

website/docs/r/team.html.markdown

@@ -38,7 +38,7 @@ The following arguments are supported:
 
 * `name` - (Required) Name of the team.
 * `organization` - (Optional) Name of the organization. If omitted, organization must be defined in the provider config.
-* `visibility` - (Optional) The visibility of the team ("secret" or "organization"). Defaults to "secret".
+* `visibility` - (Optional) The visibility of the team ("secret" or "organization")
 * `organization_access` - (Optional) Settings for the team's [organization access](https://developer.hashicorp.com/terraform/cloud-docs/users-teams-organizations/permissions#organization-permissions).
 * `sso_team_id` - (Optional) Unique Identifier to control [team membership](https://developer.hashicorp.com/terraform/cloud-docs/users-teams-organizations/single-sign-on#team-names-and-sso-team-ids) via SAML. Defaults to `null`
 * `allow_member_token_management` - (Optional) Used by Owners and users with "Manage Teams" permissions to control whether team members can manage team tokens. Defaults to `true`.