maded tests generic and dependent on env var

Author: dominic-retli-hashi

internal/provider/data_source_hyok_customer_key_version_test.go

@@ -1,14 +1,20 @@
 package provider
 
 import (
-	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
-	"github.com/hashicorp/terraform-plugin-testing/echoprovider"
+	"os"
 	"testing"
 
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
+	"github.com/hashicorp/terraform-plugin-testing/echoprovider"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
 func TestAccTFEHYOKCustomerKeyVersionDataSource_basic(t *testing.T) {
+	hyokCustomerKeyVersionId := os.Getenv("HYOK_CUSTOMER_KEY_VERSION_ID")
+	if hyokCustomerKeyVersionId == "" {
+		t.Skip("HYOK_CUSTOMER_KEY_VERSION_ID environment variable must be set to run this test")
+	}
+
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
 		ProtoV5ProviderFactories: testAccMuxedProviders,
@@ -17,11 +23,11 @@ func TestAccTFEHYOKCustomerKeyVersionDataSource_basic(t *testing.T) {
 		},
 		Steps: []resource.TestStep{
 			{
-				Config: testAccTFEHYOKCustomerKeyVersionDataSourceConfig,
+				Config: testAccTFEHYOKCustomerKeyVersionDataSourceConfig(hyokCustomerKeyVersionId),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					resource.TestCheckResourceAttr("data.tfe_hyok_customer_key_version.test", "id", "keyv-BWZTzt2J75DsdwH8"),
-					resource.TestCheckResourceAttr("data.tfe_hyok_customer_key_version.test", "status", "available"),
-					resource.TestCheckResourceAttr("data.tfe_hyok_customer_key_version.test", "key_version", "10"),
+					resource.TestCheckResourceAttr("data.tfe_hyok_customer_key_version.test", "id", hyokCustomerKeyVersionId),
+					resource.TestCheckResourceAttrSet("data.tfe_hyok_customer_key_version.test", "status"),
+					resource.TestCheckResourceAttrSet("data.tfe_hyok_customer_key_version.test", "key_version"),
 					resource.TestCheckResourceAttrSet("data.tfe_hyok_customer_key_version.test", "created_at"),
 					resource.TestCheckResourceAttrSet("data.tfe_hyok_customer_key_version.test", "updated_at"),
 				),
@@ -30,12 +36,10 @@ func TestAccTFEHYOKCustomerKeyVersionDataSource_basic(t *testing.T) {
 	})
 }
 
-const testAccTFEHYOKCustomerKeyVersionDataSourceConfig = `
-data "tfe_organization" "org" {
-  name = "dretli-hyok-org"
-}
-
+func testAccTFEHYOKCustomerKeyVersionDataSourceConfig(id string) string {
+	return `
 data "tfe_hyok_customer_key_version" "test" {
-  id = "keyv-BWZTzt2J75DsdwH8"
+  id = "` + id + `"
 }
 `
+}

internal/provider/data_source_hyok_encrypted_data_key_test.go

@@ -1,14 +1,20 @@
 package provider
 
 import (
-	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
-	"github.com/hashicorp/terraform-plugin-testing/echoprovider"
+	"os"
 	"testing"
 
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
+	"github.com/hashicorp/terraform-plugin-testing/echoprovider"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
 func TestAccTFEHYOKEncryptedDataKeyDataSource_basic(t *testing.T) {
+	hyokEncryptedDataKeyID := os.Getenv("HYOK_ENCRYPTED_DATA_KEY_ID")
+	if hyokEncryptedDataKeyID == "" {
+		t.Skip("HYOK_ENCRYPTED_DATA_KEY_ID environment variable must be set to run this test")
+	}
+
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
 		ProtoV5ProviderFactories: testAccMuxedProviders,
@@ -17,24 +23,22 @@ func TestAccTFEHYOKEncryptedDataKeyDataSource_basic(t *testing.T) {
 		},
 		Steps: []resource.TestStep{
 			{
-				Config: testAccTFEHYOKEncryptedDataKeyDataSourceConfig,
+				Config: testAccTFEHYOKEncryptedDataKeyDataSourceConfig(hyokEncryptedDataKeyID),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					resource.TestCheckResourceAttr("data.tfe_hyok_encrypted_data_key.test", "id", "dek-wuLiejfGtNLLuiH9"),
-					resource.TestCheckResourceAttr("data.tfe_hyok_encrypted_data_key.test", "encrypted_dek", "dmF1bHQ6djEwOjdFb3gzNERXQ05zNGVNelNSb09waWp3dGE4SmlNa0JjWFRsQ25KbXlRNlZWRGpCbnFtOFBvbGkvb1ZGTkQ3UVFybDNoNzBrT2hScnlHUlZS"),
-					resource.TestCheckResourceAttr("data.tfe_hyok_encrypted_data_key.test", "customer_key_name", "tf-rocket-hyok-oasis"),
+					resource.TestCheckResourceAttr("data.tfe_hyok_encrypted_data_key.test", "id", hyokEncryptedDataKeyID),
+					resource.TestCheckResourceAttrSet("data.tfe_hyok_encrypted_data_key.test", "encrypted_dek"),
+					resource.TestCheckResourceAttrSet("data.tfe_hyok_encrypted_data_key.test", "customer_key_name"),
 					resource.TestCheckResourceAttrSet("data.tfe_hyok_encrypted_data_key.test", "created_at"),
 				),
 			},
 		},
 	})
 }
 
-const testAccTFEHYOKEncryptedDataKeyDataSourceConfig = `
-data "tfe_organization" "org" {
-  name = "dretli-hyok-org"
-}
-
+func testAccTFEHYOKEncryptedDataKeyDataSourceConfig(id string) string {
+	return `
 data "tfe_hyok_encrypted_data_key" "test" {
-  id = "dek-wuLiejfGtNLLuiH9"
+  id = "` + id + `"
 }
 `
+}