test

Author: hashimoon

internal/provider/resource_tfe_registry_module.go

@@ -22,6 +22,8 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
+var ctx = context.Background()
+
 func resourceTFERegistryModule() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceTFERegistryModuleCreate,
@@ -578,13 +580,16 @@ func validateTestConfig(d *schema.ResourceDiff) error {
 	}
 
 	testConfigValue := testConfig.AsValueSlice()[0]
-	agentExecutionModeValue := testConfigValue.GetAttr("agent_execution_mode")
-	agentPoolIDValue := testConfigValue.GetAttr("agent_pool_id")
 
-	if agentExecutionModeValue.IsNull() && agentPoolIDValue.IsNull() {
-		return nil
+	// Check if test_config block is empty (no tests_enabled field)
+	testsEnabledValue := testConfigValue.GetAttr("tests_enabled")
+	if testsEnabledValue.IsNull() {
+		return fmt.Errorf("tests_enabled must be provided when configuring a test_config")
 	}
 
+	agentExecutionModeValue := testConfigValue.GetAttr("agent_execution_mode")
+	agentPoolIDValue := testConfigValue.GetAttr("agent_pool_id")
+
 	// Skip validation if values are unknown (during plan phase)
 	if !agentExecutionModeValue.IsKnown() || !agentPoolIDValue.IsKnown() {
 		return nil

internal/provider/resource_tfe_registry_module_test.go

@@ -4,6 +4,7 @@
 package provider
 
 import (
+	"context"
 	"fmt"
 	"math/rand"
 	"regexp"
@@ -17,6 +18,8 @@ import (
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 )
 
+var ctx = context.Background()
+
 func TestAccTFERegistryModule_vcsBasic(t *testing.T) {
 	registryModule := &tfe.RegistryModule{}
 	rInt := rand.New(rand.NewSource(time.Now().UnixNano())).Int()
@@ -666,7 +669,7 @@ func TestAccTFERegistryModuleImport_vcsPublishingMechanismTagsToBranchToTags(t *
 				Config: testAccTFERegistryModule_vcsTags(rInt),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("tfe_registry_module.foobar", "publishing_mechanism", "git_tag"),
-					resource.TestCheckNoResourceAttr("tfe_registry_module.foobar", "test_config.0.tests_enabled"),
+					resource.TestCheckNoResourceAttr("tfe_registry_module.foobar", "test_config.0"),
 					resource.TestCheckResourceAttr("tfe_registry_module.foobar", "vcs_repo.0.tags", strconv.FormatBool(true)),
 					resource.TestCheckResourceAttr("tfe_registry_module.foobar", "vcs_repo.0.branch", ""),
 				),
@@ -686,7 +689,7 @@ func TestAccTFERegistryModule_invalidTestConfigOnCreate(t *testing.T) {
 		ProtoV6ProviderFactories: testAccMuxedProviders,
 		Steps: []resource.TestStep{
 			{
-				Config:      testAccTFERegistryModule_vcsInvalidBranch(rInt),
+				Config:      testAccTFERegistryModule_invalidTestConfig(rInt),
 				ExpectError: regexp.MustCompile(`tests_enabled must be provided when configuring a test_config`),
 			},
 		},