linting fixes

Author: drewmullen

internal/provider/data_source_registry_module.go

@@ -42,7 +42,7 @@ type modelRegistryModule struct {
 	Name                types.String                         `tfsdk:"name"`
 	RegistryName        types.String                         `tfsdk:"registry_name"`
 	ModuleProvider      types.String                         `tfsdk:"module_provider"`
-	NoCodeModuleId      types.String                         `tfsdk:"no_code_module_id"`
+	NoCodeModuleID      types.String                         `tfsdk:"no_code_module_id"`
 	NoCodeModuleSource  types.String                         `tfsdk:"no_code_module_source"`
 	NoCode              types.Bool                           `tfsdk:"no_code"`
 	Permissions         []modelRegistryModulePermissions     `tfsdk:"permissions"`
@@ -372,7 +372,6 @@ func (d *dataSourceTFERegistryModule) Read(ctx context.Context, req datasource.R
 		Provider:     data.ModuleProvider.ValueString(),
 		Namespace:    namespace.ValueString(),
 		RegistryName: tfe.RegistryName(registryName.ValueString()),
-		//tfe.RegistryName(data.RegistryName.ValueString()),
 	}
 
 	tflog.Debug(ctx, "Reading module")
@@ -416,7 +415,7 @@ func modelFromTFERegistryModule(v *tfe.RegistryModule) modelRegistryModule {
 	}
 	// Only valid options are no RegistryNoCodeModule or a single entry
 	if v.RegistryNoCodeModule != nil {
-		m.NoCodeModuleId = types.StringValue(v.RegistryNoCodeModule[0].ID)
+		m.NoCodeModuleID = types.StringValue(v.RegistryNoCodeModule[0].ID)
 		m.NoCodeModuleSource = types.StringValue(fmt.Sprintf("%s/%s/%s/%s", v.RegistryName, v.Namespace, v.Name, v.Provider))
 	}
 	return m

internal/provider/data_source_registry_module_test.go

@@ -14,8 +14,6 @@ import (
 )
 
 func TestAccTFERegistryModuleDataSource_basicPrivate(t *testing.T) {
-	// registryModule := &tfe.RegistryModule{}
-
 	rInt := rand.New(rand.NewSource(time.Now().UnixNano())).Int()
 	orgName := fmt.Sprintf("tst-terraform-%d", rInt)
 
@@ -38,7 +36,7 @@ func TestAccTFERegistryModuleDataSource_basicPrivate(t *testing.T) {
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "namespace", orgName),
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "name", expectedRegistryModuleAttributes.Name),
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "registry_name", string(expectedRegistryModuleAttributes.RegistryName)),
-					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "module_provider", string(expectedRegistryModuleAttributes.Provider)),
+					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "module_provider", expectedRegistryModuleAttributes.Provider),
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "no_code", "false"),
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "permissions.0.can_delete", "true"),
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "permissions.0.can_retry", "true"),
@@ -86,7 +84,7 @@ func TestAccTFERegistryModuleDataSource_basicNoCodePublic(t *testing.T) {
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "namespace", expectedRegistryModuleAttributes.Namespace),
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "name", expectedRegistryModuleAttributes.Name),
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "registry_name", string(expectedRegistryModuleAttributes.RegistryName)),
-					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "module_provider", string(expectedRegistryModuleAttributes.Provider)),
+					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "module_provider", expectedRegistryModuleAttributes.Provider),
 					resource.TestCheckResourceAttr("data.tfe_registry_module.test", "no_code_module_source", ncms),
 				),
 			},