update docs and use known length for slices

Author: notchairmk

internal/provider/resource_tfe_team_notification_configuration.go

@@ -186,7 +186,7 @@ func (r *resourceTFETeamNotificationConfiguration) Schema(ctx context.Context, r
 			},
 
 			"url": schema.StringAttribute{
-				Description: "The HTTP or HTTPS URL where notification requests will be made. This value must not be provided if `destination_type` is `email`.",
+				Description: "The HTTP or HTTPS URL where notification requests will be made. This value must not be provided if `email_addresses` or `email_user_ids` is present, or if `destination_type` is `email`.",
 				Optional:    true,
 				Validators: []validator.String{
 					validators.AttributeRequiredIfValueString(
@@ -269,7 +269,7 @@ func (r *resourceTFETeamNotificationConfiguration) Create(ctx context.Context, r
 	}
 
 	// Add email_addresses set to the options struct
-	emailAddresses := make([]types.String, 0)
+	emailAddresses := make([]types.String, len(plan.EmailAddresses.Elements()))
 	if diags := plan.EmailAddresses.ElementsAs(ctx, &emailAddresses, true); diags != nil && diags.HasError() {
 		resp.Diagnostics.Append(diags...)
 		return
@@ -362,7 +362,7 @@ func (r *resourceTFETeamNotificationConfiguration) Update(ctx context.Context, r
 	}
 
 	// Add triggers set to the options struct
-	triggers := make([]types.String, 0)
+	triggers := make([]types.String, len(plan.Triggers.Elements()))
 	if diags := plan.Triggers.ElementsAs(ctx, &triggers, true); diags != nil && diags.HasError() {
 		resp.Diagnostics.Append(diags...)
 		return
@@ -373,7 +373,7 @@ func (r *resourceTFETeamNotificationConfiguration) Update(ctx context.Context, r
 	}
 
 	// Add email_addresses set to the options struct
-	emailAddresses := make([]types.String, 0)
+	emailAddresses := make([]types.String, len(plan.EmailAddresses.Elements()))
 	if diags := plan.EmailAddresses.ElementsAs(ctx, &emailAddresses, true); diags != nil && diags.HasError() {
 		resp.Diagnostics.Append(diags...)
 		return
@@ -384,7 +384,7 @@ func (r *resourceTFETeamNotificationConfiguration) Update(ctx context.Context, r
 	}
 
 	// Add email_user_ids set to the options struct
-	emailUserIDs := make([]types.String, 0)
+	emailUserIDs := make([]types.String, len(plan.EmailUserIDs.Elements()))
 	if diags := plan.EmailUserIDs.ElementsAs(ctx, &emailUserIDs, true); diags != nil && diags.HasError() {
 		resp.Diagnostics.Append(diags...)
 		return

website/docs/r/team_notification_configuration.html.markdown

@@ -114,6 +114,8 @@ The following arguments are supported:
   - `email` available in HCP Terraform or Terraform Enterprise v202005-1 or later
   - `slack`
   - `microsoft-teams` available in HCP Terraform or Terraform Enterprise v202206-1 or later
+- `team_id` - (Required) The ID of the team that owns the notification configuration.
+- `url` - (Required if `destination_type` is `generic`, `microsoft-teams`, or `slack`) The HTTP or HTTPS URL of the notification configuration where notification requests will be made. This value _must not_ be provided if `destination_type` is `email`.
 - `email_addresses` - (Optional) **TFE only** A list of email addresses. This value
   _must not_ be provided if `destination_type` is `generic`, `microsoft-teams`, or `slack`.
 - `email_user_ids` - (Optional) A list of user IDs. This value _must not_ be provided
@@ -126,8 +128,6 @@ The following arguments are supported:
   This value _must not_ be provided if `destination_type` is `email`, `microsoft-teams`, or `slack`.
 - `triggers` - (Optional) The array of triggers for which this notification configuration will
   send notifications. Currently, the only valid value is `change_request:created`.
-- `url` - (Required if `destination_type` is `generic`, `microsoft-teams`, or `slack`) The HTTP or HTTPS URL of the notification configuration where notification requests will be made. This value _must not_ be provided if `destination_type` is `email`.
-- `team_id` - (Required) The ID of the team that owns the notification configuration.
 
 ## Attributes Reference