Merge pull request #37713 from hashicorp/jbardin/list-gen-config

get correct schema when generating query config

Author: jbardin

internal/command/query_test.go

@@ -536,7 +536,7 @@ func TestQuery_JSON(t *testing.T) {
 							"ami": "ami-12345",
 							"id":  "test-instance-1",
 						},
-						"config":        "resource \"test_instance\" \"example_0\" {\n  provider = test\n  ami      = \"ami-12345\"\n  id       = \"test-instance-1\"\n}",
+						"config":        "resource \"test_instance\" \"example_0\" {\n  provider = test\n  ami      = \"ami-12345\"\n}",
 						"import_config": "import {\n  to       = test_instance.example_0\n  provider = test\n  identity = {\n    id = \"test-instance-1\"\n  }\n}",
 					},
 					"type": "list_resource_found",
@@ -556,7 +556,7 @@ func TestQuery_JSON(t *testing.T) {
 							"ami": "ami-67890",
 							"id":  "test-instance-2",
 						},
-						"config":        "resource \"test_instance\" \"example_1\" {\n  provider = test\n  ami      = \"ami-67890\"\n  id       = \"test-instance-2\"\n}",
+						"config":        "resource \"test_instance\" \"example_1\" {\n  provider = test\n  ami      = \"ami-67890\"\n}",
 						"import_config": "import {\n  to       = test_instance.example_1\n  provider = test\n  identity = {\n    id = \"test-instance-2\"\n  }\n}",
 					},
 					"type": "list_resource_found",

internal/terraform/context_plan_query_test.go

@@ -30,7 +30,10 @@ func TestContext2Plan_queryList(t *testing.T) {
 		instanceTypes := []string{"ami-123456", "ami-654321", "ami-789012"}
 		madeUp := []cty.Value{}
 		for i := range len(instanceTypes) {
-			madeUp = append(madeUp, cty.ObjectVal(map[string]cty.Value{"instance_type": cty.StringVal(instanceTypes[i])}))
+			madeUp = append(madeUp, cty.ObjectVal(map[string]cty.Value{
+				"instance_type": cty.StringVal(instanceTypes[i]),
+				"id":            cty.StringVal(fmt.Sprint(i)),
+			}))
 		}
 
 		ids := []cty.Value{}
@@ -1004,6 +1007,10 @@ func getListProviderSchemaResp() *providers.GetProviderSchemaResponse {
 						Computed: true,
 						Optional: true,
 					},
+					"id": {
+						Type:     cty.String,
+						Computed: true,
+					},
 				},
 			},
 			"test_child_resource": {

internal/terraform/node_resource_plan_instance.go

@@ -977,10 +977,17 @@ func (n *NodePlannableResourceInstance) generateResourceConfig(ctx EvalContext,
 	if diags.HasErrors() {
 		return cty.DynamicVal, diags
 	}
-	schema := providerSchema.SchemaForResourceAddr(n.Addr.Resource.Resource)
+
+	// the calling node may be a list resource, in which case we still need to
+	// lookup the schema for the corresponding managed resource for generating
+	// configuration.
+	managedAddr := n.Addr.Resource.Resource
+	managedAddr.Mode = addrs.ManagedResourceMode
+
+	schema := providerSchema.SchemaForResourceAddr(managedAddr)
 	if schema.Body == nil {
 		// Should be caught during validation, so we don't bother with a pretty error here
-		diags = diags.Append(fmt.Errorf("provider does not support resource type for %q", n.Addr))
+		diags = diags.Append(fmt.Errorf("provider does not support resource type for %q", managedAddr))
 		return cty.DynamicVal, diags
 	}