Make dynamic reference error message more precise

Author: dbanck

internal/terraform/context_init_test.go

@@ -235,7 +235,7 @@ module "example" {
 				return tfdiags.Diagnostics{}.Append(&hcl.Diagnostic{
 					Severity: hcl.DiagError,
 					Summary:  `Invalid module source`,
-					Detail:   `The module source can only reference input variables and local values.`,
+					Detail:   `The module source can only reference constant input variables and local values.`,
 					Subject: &hcl.Range{
 						Filename: filepath.Join(m.SourceDir, "main.tf"),
 						Start:    hcl.Pos{Line: 4, Column: 31, Byte: 95},
@@ -317,7 +317,7 @@ module "example" {
 				return tfdiags.Diagnostics{}.Append(&hcl.Diagnostic{
 					Severity: hcl.DiagError,
 					Summary:  "Invalid module source",
-					Detail:   "The module source can only reference input variables and local values.",
+					Detail:   "The module source can only reference constant input variables and local values.",
 					Subject: &hcl.Range{
 						Filename: filepath.Join(m.SourceDir, "main.tf"),
 						Start:    hcl.Pos{Line: 5, Column: 33, Byte: 91},
@@ -402,7 +402,7 @@ output "id" {
 				return tfdiags.Diagnostics{}.Append(&hcl.Diagnostic{
 					Severity: hcl.DiagError,
 					Summary:  "Invalid module source",
-					Detail:   "The module source can only reference input variables and local values.",
+					Detail:   "The module source can only reference constant input variables and local values.",
 					Subject: &hcl.Range{
 						Filename: filepath.Join(m.SourceDir, "main.tf"),
 						Start:    hcl.Pos{Line: 7, Column: 33, Byte: 107},

internal/terraform/node_module_install.go

@@ -173,7 +173,7 @@ func evalSource(sourceExpr hcl.Expression, hasVersion bool, ctx EvalContext) (ad
 			diags = diags.Append(&hcl.Diagnostic{
 				Severity: hcl.DiagError,
 				Summary:  "Invalid module source",
-				Detail:   "The module source can only reference input variables and local values.",
+				Detail:   "The module source can only reference constant input variables and local values.",
 				Subject:  ref.SourceRange.ToHCL().Ptr(),
 			})
 			return nil, "", diags
@@ -310,7 +310,7 @@ func evalVersionConstraint(versionExpr hcl.Expression, ctx EvalContext) (configs
 			diags = diags.Append(&hcl.Diagnostic{
 				Severity: hcl.DiagError,
 				Summary:  "Invalid module version",
-				Detail:   "The module version can only reference input variables and local values.",
+				Detail:   "The module version can only reference constant input variables and local values.",
 				Subject:  ref.SourceRange.ToHCL().Ptr(),
 			})
 			return ret, diags