actions: don't panic if nil changes - it might be a refresh (#37687)

mildwonkey · web-flow · commit 8ed2f3908795 · 2025-09-26T12:57:37.000-04:00
diff --git a/internal/terraform/node_action_trigger_instance_plan.go b/internal/terraform/node_action_trigger_instance_plan.go
@@ -7,6 +7,7 @@ import (
 	"fmt"
 
 	"github.com/hashicorp/hcl/v2"
+	"github.com/zclconf/go-cty/cty"
 
 	"github.com/hashicorp/terraform/internal/addrs"
 	"github.com/hashicorp/terraform/internal/configs"
@@ -17,7 +18,6 @@ import (
 	"github.com/hashicorp/terraform/internal/plans/deferring"
 	"github.com/hashicorp/terraform/internal/providers"
 	"github.com/hashicorp/terraform/internal/tfdiags"
-	"github.com/zclconf/go-cty/cty"
 )
 
 type nodeActionTriggerPlanInstance struct {
@@ -89,7 +89,8 @@ func (n *nodeActionTriggerPlanInstance) Execute(ctx EvalContext, operation walkO
 	}
 
 	if change == nil {
-		panic("change cannot be nil")
+		// nothing to do (this may be a refresh )
+		return nil
 	}
 
 	if n.lifecycleActionTrigger == nil {

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ import (`
`7`	`7`	`"fmt"`
`8`	`8`
`9`	`9`	`"github.com/hashicorp/hcl/v2"`
	`10`	`+ "github.com/zclconf/go-cty/cty"`
`10`	`11`
`11`	`12`	`"github.com/hashicorp/terraform/internal/addrs"`
`12`	`13`	`"github.com/hashicorp/terraform/internal/configs"`
`@@ -17,7 +18,6 @@ import (`
`17`	`18`	`"github.com/hashicorp/terraform/internal/plans/deferring"`
`18`	`19`	`"github.com/hashicorp/terraform/internal/providers"`
`19`	`20`	`"github.com/hashicorp/terraform/internal/tfdiags"`
`20`		`- "github.com/zclconf/go-cty/cty"`
`21`	`21`	`)`
`22`	`22`
`23`	`23`	`type nodeActionTriggerPlanInstance struct {`
`@@ -89,7 +89,8 @@ func (n *nodeActionTriggerPlanInstance) Execute(ctx EvalContext, operation walkO`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`if change == nil {`
`92`		`- panic("change cannot be nil")`
	`92`	`+ // nothing to do (this may be a refresh )`
	`93`	`+ return nil`
`93`	`94`	`}`
`94`	`95`
`95`	`96`	`if n.lifecycleActionTrigger == nil {`