-
Notifications
You must be signed in to change notification settings - Fork 10.1k
terraform init log timestamps include millisecond precision #37818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform init log timestamps include millisecond precision #37818
Conversation
Terraform init json logs omit millisecond precision included in other logs
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This uses the `terraform init -json` logs to add more visibility into the `init` phase of `plan`. The `init` logs omit `ms` precision, so we have to use `time.Now()` 😢 Open TF PR: hashicorp/terraform#37818
|
Hi @Emyrk, thank you for identifying this inconsistency and proposing a fix! I'm asking around internally about whether this would be a breaking change for our systems that consume these logs, and once I know more I'll report back. |
Thank you! Feel free to take over this PR or open a new one. These are logs I was attempting to use, but without the ms precision, the value was removed. Since many |
|
Thanks for bearing with me on this! Given the tests here and some internal conversations with people who work on HCP Terraform I'm happy to go ahead and merge this. Thanks again 🚀 |
…ecision (#37818) * fix: terraform init log timestamps include millisecond precision * docs: add changelog entry
|
@SarahFrench thank you! |
Terraform init json logs to include millisecond precision. Following the trend of other logs.
Example output:
The timestamps for
init_outputomit milliseconds.Target Release
1.15.x
CHANGELOG entry