Skip to content

Commit 9b84edd

Browse files
committed
Added metrics to count the number of rollout restarts
Fixes #1129
1 parent 49f32c3 commit 9b84edd

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

helpers/rollout_restart.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919

2020
"github.com/hashicorp/vault-secrets-operator/api/v1beta1"
2121
"github.com/hashicorp/vault-secrets-operator/consts"
22+
"github.com/hashicorp/vault-secrets-operator/internal/metrics"
2223
)
2324

2425
// AnnotationRestartedAt is updated to trigger a rollout-restart
@@ -62,9 +63,11 @@ func HandleRolloutRestarts(ctx context.Context, client ctrlclient.Client, obj ct
6263
errs = errors.Join(err)
6364
recorder.Eventf(obj, corev1.EventTypeWarning, consts.ReasonRolloutRestartFailed,
6465
"Rollout restart failed for target %#v: err=%s", target, err)
66+
metrics.RolloutRestartsErrors.WithLabelValues(obj.GetNamespace(), obj.GetName(), target.Name, target.Kind).Inc()
6567
} else {
6668
recorder.Eventf(obj, corev1.EventTypeNormal, consts.ReasonRolloutRestartTriggered,
6769
"Rollout restart triggered for %v", target)
70+
metrics.RolloutRestartsTotal.WithLabelValues(obj.GetNamespace(), obj.GetName(), target.Name, target.Kind).Inc()
6871
}
6972
}
7073

internal/metrics/metrics.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ const (
3939
NameRequestsTotal = "requests_total"
4040
NameRequestsErrorsTotal = "requests_errors_total"
4141
NameTaintedClients = "tainted_clients"
42+
subsystemRolloutRestarts = "rollout_restarts"
4243
)
4344

4445
var ResourceStatus = prometheus.NewGaugeVec(prometheus.GaugeOpts{
@@ -50,6 +51,18 @@ var ResourceStatus = prometheus.NewGaugeVec(prometheus.GaugeOpts{
5051
"namespace",
5152
})
5253

54+
var RolloutRestartsTotal = prometheus.NewCounterVec(prometheus.CounterOpts{
55+
Name: prometheus.BuildFQName(
56+
Namespace, subsystemRolloutRestarts, "total"),
57+
Help: "Number of total rollout restarts.",
58+
}, []string{"namespace", "name", "target_name", "target_kind"})
59+
60+
var RolloutRestartsErrors = prometheus.NewCounterVec(prometheus.CounterOpts{
61+
Name: prometheus.BuildFQName(
62+
Namespace, subsystemRolloutRestarts, "errors_total"),
63+
Help: "Number of total rollout restarts.",
64+
}, []string{"namespace", "name", "target_name", "target_kind"})
65+
5366
func MustRegisterResourceStatus() {
5467
metrics.Registry.MustRegister(
5568
ResourceStatus,

0 commit comments

Comments
 (0)