change break to return to prevent for loop break issue

jaireddjawed · jaireddjawed · commit a7c115328eb1 · 2025-01-31T09:32:00.000-08:00
diff --git a/controllers/hcpvaultsecretsapp_controller.go b/controllers/hcpvaultsecretsapp_controller.go
@@ -303,7 +303,7 @@ func (r *HCPVaultSecretsAppReconciler) startOrphanedShadowSecretCleanup(ctx cont
 				if ctx.Err() != nil {
 					err = ctx.Err()
 				}
-				break
+				return
 			// runs the cleanup process once every hour or as specified by the user
 			case <-time.After(cleanupOrphanedShadowSecretInterval):
 				r.cleanupOrphanedShadowSecrets(ctx)

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ func (r *HCPVaultSecretsAppReconciler) startOrphanedShadowSecretCleanup(ctx cont`
`303`	`303`	`if ctx.Err() != nil {`
`304`	`304`	`err = ctx.Err()`
`305`	`305`	`}`
`306`		`- break`
	`306`	`+ return`
`307`	`307`	`// runs the cleanup process once every hour or as specified by the user`
`308`	`308`	`case <-time.After(cleanupOrphanedShadowSecretInterval):`
`309`	`309`	`r.cleanupOrphanedShadowSecrets(ctx)`