Add new Client for caching VSO owned Secrets#1010
Merged
Conversation
jaireddjawed
approved these changes
Feb 12, 2025
benashz
deleted the
VAULT-33411/selectively-cache-vso-managed-secrets
branch
Collaborator
Author
|
Tests to be added in a follow-on PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #982 we disabled caching of all K8s Secrets to address an issue where VSO was being OOM killed due to the cluster having a large amount of secret data. That change had the side-effect of increasing the number API calls being made to K8s. This PR should reduce the number of calls needed on a cluster running thousands of Vault*Secret instances.
Closes #1000