review and format fixes

Author: lunelson

apps/hash-ai-agent/package.json

@@ -63,6 +63,7 @@
     "@types/papaparse": "5.3.16",
     "@types/sanitize-html": "2.16.0",
     "@vitest/coverage-istanbul": "3.2.4",
+    "baseline-browser-mapping": "2.9.11",
     "eslint": "9.38.0",
     "jsdom": "24.1.3",
     "mastra": "1.0.0-beta.5",

apps/hash-ai-agent/src/mastra/scorers/plan-scorers.ts

@@ -439,10 +439,16 @@ export function scoreUnknownsCoverage(
 ): ScorerResult<UnknownsCoverageDetails> {
   const { unknownsMap } = plan;
 
+  // Unknown-unknowns: having 1-3 with detection signals is excellent
+  // Check that each has both potentialSurprise and detectionSignal
+  const validUnknownUnknowns = unknownsMap.unknownUnknowns.filter(
+    (uu) => uu.potentialSurprise.length > 10 && uu.detectionSignal.length > 10,
+  );
+
   const details: UnknownsCoverageDetails = {
     knownKnownsCount: unknownsMap.knownKnowns.length,
     knownUnknownsCount: unknownsMap.knownUnknowns.length,
-    unknownUnknownsCount: unknownsMap.unknownUnknowns.length,
+    unknownUnknownsCount: validUnknownUnknowns.length,
     hasCommunityCheck: unknownsMap.communityCheck.length > 20,
     epistemicCompleteness: 0,
   };
@@ -454,11 +460,6 @@ export function scoreUnknownsCoverage(
   // Known-unknowns: having 2-5 is good
   const knownUnknownsScore = Math.min(1, details.knownUnknownsCount / 3);
 
-  // Unknown-unknowns: having 1-3 with detection signals is excellent
-  // Check that each has both potentialSurprise and detectionSignal
-  const validUnknownUnknowns = unknownsMap.unknownUnknowns.filter(
-    (uu) => uu.potentialSurprise.length > 10 && uu.detectionSignal.length > 10,
-  );
   const unknownUnknownsScore = Math.min(1, validUnknownUnknowns.length / 2);
 
   // Community check: should be substantive
@@ -475,7 +476,7 @@ export function scoreUnknownsCoverage(
   const reason =
     `Epistemic coverage: ${details.knownKnownsCount} known-knowns, ` +
     `${details.knownUnknownsCount} known-unknowns, ` +
-    `${validUnknownUnknowns.length} unknown-unknowns with detection signals. ` +
+    `${details.unknownUnknownsCount} unknown-unknowns with detection signals. ` +
     `Community check: ${details.hasCommunityCheck ? "present" : "missing/weak"}.`;
 
   return { score, reason, details };
@@ -530,7 +531,12 @@ export function scorePlanComposite(
   // Guard against division by zero (all weights are 0)
   const resolvedWeights =
     weightSum === 0
-      ? { structure: 0.25, coverage: 0.3, experimentRigor: 0.25, unknownsCoverage: 0.2 }
+      ? {
+          structure: 0.25,
+          coverage: 0.3,
+          experimentRigor: 0.25,
+          unknownsCoverage: 0.2,
+        }
       : {
           structure: rawWeights.structure / weightSum,
           coverage: rawWeights.coverage / weightSum,

yarn.lock

@@ -608,6 +608,7 @@ __metadata:
     "@types/papaparse": "npm:5.3.16"
     "@types/sanitize-html": "npm:2.16.0"
     "@vitest/coverage-istanbul": "npm:3.2.4"
+    baseline-browser-mapping: "npm:2.9.11"
     dedent: "npm:1.7.0"
     es-toolkit: "npm:1.41.0"
     eslint: "npm:9.38.0"
@@ -24109,12 +24110,12 @@ __metadata:
   languageName: node
   linkType: hard
 
-"baseline-browser-mapping@npm:^2.8.9":
-  version: 2.8.18
-  resolution: "baseline-browser-mapping@npm:2.8.18"
+"baseline-browser-mapping@npm:2.9.11, baseline-browser-mapping@npm:^2.8.9":
+  version: 2.9.11
+  resolution: "baseline-browser-mapping@npm:2.9.11"
   bin:
     baseline-browser-mapping: dist/cli.js
-  checksum: 10c0/fa319aab5761ccb78ec7f5e5905149ae1916d65b68009aa1c8b6ec7f0bdb878bfa57a553235024179ed5ba8b36d668a22f599861990ce6ceb1aeeafb1e5704ae
+  checksum: 10c0/eba49fcc1b33ab994aeeb73a4848f2670e06a0886dd5b903689ae6f60d47e7f1bea9262dbb2548c48179e858f7eda2b82ddf941ae783b862f4dcc51085a246f2
   languageName: node
   linkType: hard