fix: suggestions from code review

indietyp · indietyp · commit ef6aeec9b6d7 · 2026-02-06T10:37:03.000+01:00
diff --git a/libs/@local/hashql/core/src/id/bit_vec/finite.rs b/libs/@local/hashql/core/src/id/bit_vec/finite.rs
@@ -306,7 +306,12 @@ impl<I, T: FiniteBitSetIntegral> Hash for FiniteBitSet<I, T> {
 
 impl<I: Id, T: FiniteBitSetIntegral> Debug for FiniteBitSet<I, T> {
     fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(fmt, "{:032b}", self.store)
+        write!(
+            fmt,
+            "{:0width$b}",
+            self.store,
+            width = (T::MAX_DOMAIN_SIZE as usize)
+        )
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,12 @@ impl<I, T: FiniteBitSetIntegral> Hash for FiniteBitSet<I, T> {`
`306`	`306`
`307`	`307`	`impl<I: Id, T: FiniteBitSetIntegral> Debug for FiniteBitSet<I, T> {`
`308`	`308`	`fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {`
`309`		`- write!(fmt, "{:032b}", self.store)`
	`309`	`+ write!(`
	`310`	`+ fmt,`
	`311`	`+ "{:0width$b}",`
	`312`	`+ self.store,`
	`313`	`+ width = (T::MAX_DOMAIN_SIZE as usize)`
	`314`	`+ )`
`310`	`315`	`}`
`311`	`316`	`}`
`312`	`317`