Add tests for anonymous queries w|w/o variables

Added tests in ASTTests.hs:
- parses anonymous query documents
  - changed previous test of same name to: parses shorthand syntax documents
- parses anonymous query with variables

Added tests in ValidationTests.hs:
- Treats anonymous queries as valid
- Treats anonymous queries with variables as valid

Author: sunwukonga

src/GraphQL/Internal/Name.hs

@@ -6,6 +6,7 @@
 {-# LANGUAGE ScopedTypeVariables #-}
 module GraphQL.Internal.Name
   ( Name(unName, Name)
+  , mempty
   , NameError(..)
   , makeName
   , nameFromSymbol

tests/ASTTests.hs

@@ -13,7 +13,7 @@ import Test.Tasty (TestTree)
 import Test.Tasty.Hspec (testSpec, describe, it, shouldBe)
 
 import GraphQL.Value (String(..))
-import GraphQL.Internal.Name (Name)
+import GraphQL.Internal.Name (Name (Name), mempty)
 import qualified GraphQL.Internal.Syntax.AST as AST
 import qualified GraphQL.Internal.Syntax.Parser as Parser
 import qualified GraphQL.Internal.Syntax.Encoder as Encoder
@@ -78,7 +78,7 @@ tests = testSpec "AST" $ do
         output `shouldBe` "[1.5,1.5]"
         parseOnly Parser.value output `shouldBe` Right input
   describe "Parser" $ do
-    it "parses anonymous query documents" $ do
+    it "parses shorthand syntax documents" $ do
       let query = [r|{
                        dog {
                          name
@@ -96,6 +96,25 @@ tests = testSpec "AST" $ do
                      ]
       parsed `shouldBe` expected
 
+    it "parses anonymous query documents" $ do
+      let query = [r|query {
+                       dog {
+                         name
+                       }
+                     }|]
+      let Right parsed = parseOnly Parser.queryDocument query
+      let expected = AST.QueryDocument
+                     [ AST.DefinitionOperation
+                       (AST.Query
+                         (AST.Node (Name mempty) [] []
+                           [ AST.SelectionField
+                             (AST.Field Nothing dog [] []
+                               [ AST.SelectionField (AST.Field Nothing someName [] [] [])
+                               ])
+                           ]))
+                     ]
+      parsed `shouldBe` expected
+
     it "parses invalid documents" $ do
       let query = [r|{
                        dog {
@@ -162,3 +181,33 @@ tests = testSpec "AST" $ do
                             ]))
                      ]
       parsed `shouldBe` expected
+
+    it "parses anonymous query with variables" $ do
+      let query = [r|
+                    query ($atOtherHomes: Boolean = true) {
+                      dog {
+                        isHousetrained(atOtherHomes: $atOtherHomes)
+                      }
+                    }
+                    |]
+      let Right parsed = parseOnly Parser.queryDocument query
+      let expected = AST.QueryDocument
+                     [ AST.DefinitionOperation
+                         (AST.Query
+                           (AST.Node (Name mempty)
+                            [ AST.VariableDefinition
+                                (AST.Variable "atOtherHomes")
+                                (AST.TypeNamed (AST.NamedType "Boolean"))
+                                (Just (AST.ValueBoolean True))
+                            ] []
+                            [ AST.SelectionField
+                                (AST.Field Nothing dog [] []
+                                 [ AST.SelectionField
+                                     (AST.Field Nothing "isHousetrained"
+                                      [ AST.Argument "atOtherHomes"
+                                          (AST.ValueVariable (AST.Variable "atOtherHomes"))
+                                      ] [] [])
+                                 ])
+                            ]))
+                     ]
+      parsed `shouldBe` expected

tests/ValidationTests.hs

@@ -10,7 +10,7 @@ import Test.QuickCheck ((===))
 import Test.Tasty (TestTree)
 import Test.Tasty.Hspec (testSpec, describe, it, shouldBe)
 
-import GraphQL.Internal.Name (Name)
+import GraphQL.Internal.Name (Name(Name), mempty)
 import qualified GraphQL.Internal.Syntax.AST as AST
 import GraphQL.Internal.Schema (Schema)
 import GraphQL.Internal.Validation
@@ -25,6 +25,9 @@ me = "me"
 someName :: Name
 someName = "name"
 
+dog :: Name
+dog = "dog"
+
 -- | Schema used for these tests. Since none of them do type-level stuff, we
 -- don't need to define it.
 schema :: Schema
@@ -45,6 +48,41 @@ tests = testSpec "Validation" $ do
                 ]
       getErrors schema doc `shouldBe` []
 
+    it "Treats anonymous queries as valid" $ do
+      let doc = AST.QueryDocument
+                [ AST.DefinitionOperation
+                  (AST.Query
+                    (AST.Node (Name mempty) [] []
+                      [ AST.SelectionField
+                        (AST.Field Nothing dog [] []
+                          [ AST.SelectionField (AST.Field Nothing someName [] [] [])
+                          ])
+                      ]))
+                ]
+      getErrors schema doc `shouldBe` []
+
+    it "Treats anonymous queries with variables as valid" $ do
+      let doc = AST.QueryDocument
+                [ AST.DefinitionOperation
+                    (AST.Query
+                      (AST.Node (Name mempty)
+                       [ AST.VariableDefinition
+                           (AST.Variable "atOtherHomes")
+                           (AST.TypeNamed (AST.NamedType "Boolean"))
+                           (Just (AST.ValueBoolean True))
+                       ] []
+                       [ AST.SelectionField
+                           (AST.Field Nothing dog [] []
+                            [ AST.SelectionField
+                                (AST.Field Nothing "isHousetrained"
+                                 [ AST.Argument "atOtherHomes"
+                                     (AST.ValueVariable (AST.Variable "atOtherHomes"))
+                                 ] [] [])
+                            ])
+                       ]))
+                ]
+      getErrors schema doc `shouldBe` []
+
     it "Detects duplicate operation names" $ do
       let doc = AST.QueryDocument
                 [ AST.DefinitionOperation