treewide: (toText -> fromString)

This explicitly states the code smell of String use left.

Author: Anton-Latukha

main/Main.hs

@@ -121,7 +121,7 @@ main' opts@Options{..} = runWithBasicEffectsIO opts execContentsFilesOrRepl
               either
                 (\ err -> errorWithoutStackTrace $ "Type error: " <> ppShow err)
                 (\ ty  -> liftIO $ putStrLn $ "Type of expression: " <>
-                  ppShow (fromMaybe mempty $ Map.lookup @VarName @[Scheme] "it" $ coerce ty)
+                  ppShow (maybeToMonoid Map.lookup @VarName @[Scheme] "it" $ coerce ty)
                 )
                 (HM.inferTop mempty [("it", stripAnnotation expr')])
 

main/Repl.hs

@@ -68,7 +68,7 @@ main' iniVal =
     evalStateT
       (evalRepl
         banner
-        (cmd . toText)
+        (cmd . fromString)
         options
         (pure commandPrefix)
         (pure "paste")
@@ -125,7 +125,7 @@ main' iniVal =
              -> m ()
   optMatcher s [] _ = liftIO $ Text.putStrLn $ "No such command :" <> s
   optMatcher s ((x, m) : xs) args
-    | s `Text.isPrefixOf` toText x = m $ toString args
+    | s `Text.isPrefixOf` fromString x = m $ toString args
     | otherwise = optMatcher s xs args
 
 
@@ -392,7 +392,7 @@ completeFunc reversedPrev word
     listFiles word
 
   -- Attributes of sets in REPL context
-  | var : subFields <- Text.split (== '.') (toText word) , not $ null subFields =
+  | var : subFields <- Text.split (== '.') (fromString word) , not $ null subFields =
     do
       state <- get
       maybe

src/Nix/Builtins.hs

@@ -798,7 +798,7 @@ baseNameOfNix x =
     pure $
       nvStr $
         modifyNixContents
-          (toText . takeFileName . toString)
+          (fromString . takeFileName . toString)
           ns
 
 bitAndNix
@@ -852,7 +852,7 @@ dirOfNix nvdir =
     dir <- demand nvdir
 
     case dir of
-      NVStr ns -> pure $ nvStr $ modifyNixContents (toText . takeDirectory . toString) ns
+      NVStr ns -> pure $ nvStr $ modifyNixContents (fromString . takeDirectory . toString) ns
       NVPath path -> pure $ nvPath $ coerce $ takeDirectory $ coerce path
       v -> throwError $ ErrorCall $ "dirOf: expected string or path, got " <> show v
 
@@ -1112,7 +1112,7 @@ toFileNix name s =
     mres  <-
       toFile_
         (coerce $ toString name')
-        (toString $ stringIgnoreContext s')
+        (stringIgnoreContext s')
 
     let
       t  = coerce $ toText @FilePath $ coerce mres

src/Nix/Convert.hs

@@ -399,7 +399,7 @@ instance ( Convertible e t f m
          )
   => ToValue SourcePos m (NValue' t f m (NValue t f m)) where
   toValue (SourcePos f l c) = do
-    f' <- toValue $ mkNixStringWithoutContext $ toText f
+    f' <- toValue $ mkNixStringWithoutContext $ fromString f
     l' <- toValue $ unPos l
     c' <- toValue $ unPos c
     let pos = M.fromList [("file" :: VarName, f'), ("line", l'), ("column", c')]

src/Nix/Effects.hs

@@ -137,7 +137,7 @@ instance MonadExec IO where
     (prog : args) -> do
       (exitCode, out, _) <- liftIO $ readProcessWithExitCode (toString prog) (toString <$> args) ""
       let
-        t    = Text.strip $ toText out
+        t    = Text.strip $ fromString out
         emsg = "program[" <> prog <> "] args=" <> show args
       case exitCode of
         ExitSuccess ->
@@ -194,7 +194,7 @@ instance MonadInstantiate IO where
             either
               (\ e -> Left $ ErrorCall $ "Error parsing output of nix-instantiate: " <> show e)
               pure
-              (parseNixTextLoc $ toText out)
+              (parseNixTextLoc $ fromString out)
           status -> Left $ ErrorCall $ "nix-instantiate failed: " <> show status <> ": " <> err
 
 deriving
@@ -230,12 +230,12 @@ class
 -- ** Instances
 
 instance MonadEnv IO where
-  getEnvVar            = (<<$>>) toText . lookupEnv . toString
+  getEnvVar            = (<<$>>) fromString . lookupEnv . toString
 
-  getCurrentSystemOS   = pure $ toText System.Info.os
+  getCurrentSystemOS   = pure $ fromString System.Info.os
 
   -- Invert the conversion done by GHC_CONVERT_CPU in GHC's aclocal.m4
-  getCurrentSystemArch = pure $ toText $ case System.Info.arch of
+  getCurrentSystemArch = pure $ fromString $ case System.Info.arch of
     "i386" -> "i686"
     arch   -> arch
 
@@ -438,7 +438,7 @@ addPath p =
   either
     throwError
     pure
-    =<< addToStore (toText $ takeFileName (coerce p)) p True False
+    =<< addToStore (fromString $ takeFileName (coerce p)) p True False
 
-toFile_ :: (Framed e m, MonadStore m) => Path -> String -> m StorePath
-toFile_ p contents = addTextToStore (toText p) (toText contents) mempty False
+toFile_ :: (Framed e m, MonadStore m) => Path -> Text -> m StorePath
+toFile_ p contents = addTextToStore (toText p) contents mempty False

src/Nix/Effects/Derivation.hs

@@ -76,7 +76,7 @@ writeDerivation drv@Derivation{inputs, name} = do
   let (inputSrcs, inputDrvs) = inputs
   references <- Set.fromList <$> traverse parsePath (Set.toList $ inputSrcs <> Set.fromList (Map.keys inputDrvs))
   path <- addTextToStore (Text.append name ".drv") (unparseDrv drv) (S.fromList $ Set.toList references) False
-  parsePath $ toText @Path $ coerce path
+  parsePath $ fromString $ coerce path
 
 -- | Traverse the graph of inputDrvs to replace fixed output derivations with their fixed output hash.
 -- this avoids propagating changes to their .drv when the output hash stays the same.
@@ -206,7 +206,7 @@ derivationParser = do
   pure $ Derivation {inputs = (inputSrcs, inputDrvs), ..}
  where
   s :: Parsec () Text Text
-  s = fmap toText $ string "\"" *> manyTill (escaped <|> regular) (string "\"")
+  s = fmap fromString $ string "\"" *> manyTill (escaped <|> regular) (string "\"")
   escaped = char '\\' *>
     (   '\n' <$ string "n"
     <|> '\r' <$ string "r"

src/Nix/Expr/Types.hs

@@ -267,7 +267,7 @@ data NString r
 -- | For the the 'IsString' instance, we use a plain doublequoted string.
 instance IsString (NString r) where
   fromString ""     = DoubleQuoted mempty
-  fromString string = DoubleQuoted [Plain $ toText string]
+  fromString string = DoubleQuoted [Plain $ fromString string]
 
 $(deriveShow1 ''NString)
 $(deriveRead1 ''NString)

src/Nix/Expr/Types/Annotated.hs

@@ -183,7 +183,7 @@ annNStr :: AnnUnit SrcSpan (NString NExprLoc) -> NExprLoc
 annNStr (AnnUnit s1 s) = NStrAnn s1 s
 
 deltaInfo :: SourcePos -> (Text, Int, Int)
-deltaInfo (SourcePos fp l c) = (toText fp, unPos l, unPos c)
+deltaInfo (SourcePos fp l c) = (fromString fp, unPos l, unPos c)
 
 annNNull :: NExprLoc
 annNNull = NConstantAnn nullSpan NNull

src/Nix/Parser.hs

@@ -326,7 +326,7 @@ nixString' = label "string" $ lexeme $ doubleQuoted <|> indented
     antiquoted
     <|> Plain . one <$> char '$'
     <|> esc
-    <|> Plain . toText <$> some plainChar
+    <|> Plain . fromString <$> some plainChar
    where
     plainChar :: Parser Char
     plainChar =

src/Nix/Pretty.hs

@@ -383,7 +383,7 @@ printNix = iterNValueByDiscardWith thk phi
   phi :: NValue' t f m String -> String
   phi (NVConstant' a ) = toString $ atomText a
   phi (NVStr'      ns) = show $ stringIgnoreContext ns
-  phi (NVList'     l ) = toString $ "[ " <> unwords (fmap toText l) <> " ]"
+  phi (NVList'     l ) = toString $ "[ " <> unwords (fmap fromString l) <> " ]"
   phi (NVSet' _ s) =
     "{ " <>
       concat