Skip to content

Commit 245594d

Browse files
committed
CI: Nix-dev-env-{main,macOS}: pin Nixpkgs rev
To avoid contribution loop problems, since we pin Nixpkgs in default.nix - it is logical by default CI to follow the supported way of building. The downside is - the maintainer would need to solve Nix issus when one tries to update the Nixpkgs revision.
1 parent 2cd2db9 commit 245594d

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.github/workflows/Optional-Nix-dev-env-macOS.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ on:
1313

1414

1515
env:
16-
rev: "nixos-unstable"
16+
# rev: "nixos-unstable" # 2020-09-29: NOTE: HNix default.nix currently pins the rev
1717
cachixAccount: "hnix"
1818
CACHIX_SIGNING_KEY: ${{ secrets.CACHIX_SIGNING_KEY }}
1919

.github/workflows/Optional-Nix-dev-env-main.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ env:
2222
### and the other part of keys explained in `build.sh`, since those address external procedures aound the builds.
2323
### Additional documentation is in Nixpkgs Haskell.lib: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/haskell-modules/lib.nix
2424
###
25-
rev: "nixos-unstable"
25+
# rev: "nixos-unstable" # 2020-09-29: NOTE: HNix default.nix currently pins the rev
2626
cachixAccount: "hnix"
2727
CACHIX_SIGNING_KEY: ${{ secrets.CACHIX_SIGNING_KEY }}
2828
allowInconsistentDependencies: "false"
@@ -56,7 +56,6 @@ env:
5656

5757
jobs:
5858

59-
# NOTE: Basic example
6059
build10:
6160
name: "NixOS-unstable channel, strict build, default GHC (8.8)"
6261
runs-on: ubuntu-latest
@@ -76,7 +75,6 @@ jobs:
7675
signingKey: '${{ secrets.CACHIX_SIGNING_KEY }}'
7776
- name: Determined Nix-build
7877
env:
79-
rev: "nixos-unstable"
8078
buildStrictly: "true"
8179
run: ./build.sh
8280

@@ -99,7 +97,6 @@ jobs:
9997
signingKey: '${{ secrets.CACHIX_SIGNING_KEY }}'
10098
- name: Determined Nix-build
10199
env:
102-
rev: "nixos-unstable"
103100
compiler: "ghc8101"
104101
buildFromSdist: "true"
105102
linkWithGold: "true"

0 commit comments

Comments
 (0)