-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Description
We've recently encountered a couple of issues when generating Vanilla JS code.
Firstly, when a query flag is followed by something else, the generated request looks like this:
... + '&flag'¶m=' + encodeURIComponent(param) ...
Instead of:
... + '&flag' + '¶m=' + encodeURIComponent(param) ...
It is related to #11 and is even mentioned in a comment there. This part is easy to fix and I can propose a PR for it.
The second issue is that query flags are always added to the request (see valid code above), the actual argument of the client function is not even checked. This one is similar to #16, but I think it's better to have a separate issue for query flags processing.
Metadata
Metadata
Assignees
Labels
No labels