Skip to content

Commit 1e3cbee

Browse files
authored
Remove strict data from servant{,-server}'s cabal files (#1781)
* Remove strict data from servant{,-server}'s cabal files This has triggered a regression in 0.20.2, and closes #1780 * Restore changelog-d configuration
1 parent 6014370 commit 1e3cbee

File tree

4 files changed

+21
-2
lines changed

4 files changed

+21
-2
lines changed

changelog.d/config

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
-- Possible fields for changelog entry
2+
-- synopsis: Brief description of the change. Often just the PR title.
3+
-- description: Longer description, with a list of sub-changes. Not needed for small/atomic changes.
4+
-- packages: Packages affected by the change. Omit if it's an overarching or non-package change.
5+
-- prs: Space-separated hash-prefixed pull request numbers containing the change (usually just one).
6+
-- issues: Space-separated hash-prefixed issue numbers that the change fixes/closes/affects.
7+
-- significance: Set to significant if the change is significant, that is if it warrants being put near the top of the changelog.
8+
organization: haskell-servant
9+
repository: servant
10+
required-fields: synopsis description prs
11+
packages: servant servant-server servant-client-core servant-client servant-quickcheck servant

changelog.d/issue-1780

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
synopsis: Remove -XStrictData from servant{,-server}'s cabal files
2+
packages: servant servant-server
3+
prs: #1781
4+
issues: #1780
5+
significance: significant
6+
description: {
7+
The addition of -XStrictData to servant.cabal and servant-server.cabal reduced the laziness
8+
of routing, which would trigger unimplemented endpoints using `error` or `undefined`,
9+
despite the fact that these endpoints themselves were not queried.
10+
}

servant-server/servant-server.cabal

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ common extensions
7070
RankNTypes
7171
RecordWildCards
7272
ScopedTypeVariables
73-
StrictData
7473
TupleSections
7574
TypeApplications
7675
TypeFamilies

servant/servant.cabal

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ common extensions
5858
RankNTypes
5959
RecordWildCards
6060
ScopedTypeVariables
61-
StrictData
6261
TupleSections
6362
TypeApplications
6463
TypeFamilies

0 commit comments

Comments
 (0)