Skip to content

Add MonadCatch and MonadMask instances to RouteResultT and DelayedIO #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add MonadCatch and MonadMask instances to RouteResultT and DelayedIO #1830

wants to merge 2 commits into from

Conversation

tchoutri
Copy link
Contributor

Fix #1829

@tchoutri tchoutri requested review from ysangkok and fisx June 23, 2025 13:23
@tchoutri tchoutri force-pushed the 1829-add-monadmask-monadcatch-to-delayed-io branch from 795bf9f to 1b88d8f Compare June 23, 2025 13:26
@tchoutri
Copy link
Contributor Author

@ysangkok @fisx I'd appreciate a review :)

ysangkok
ysangkok approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@ysangkok ysangkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have a test for this, since it is tricky. But it looks fine as far as I can glean.

@tchoutri
Copy link
Contributor Author

@ysangkok I'm open to suggestions for the test, my imagination is failing me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysangkok ysangkok ysangkok approved these changes

@fisx fisx Awaiting requested review from fisx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding MonadCatch and MonadMask to DelayedIO
2 participants
@tchoutri @ysangkok