Don't inline popcount

hvr · hvr · commit 446ed4ae993e · 2016-03-30T12:17:24.000+02:00
This makes no sense as we need `popcount()` to exist as external symbol. In fact this breaks with C99 compilers
which rightfully detect that `popcount` is not used at all, and therefore compile `popc.c` to an essentially empty  `popc.o` object... resulting in linker errors on GHC 7.0/7.2 when using such clever compilers...
diff --git a/cbits/popc.c b/cbits/popc.c
@@ -261,7 +261,7 @@ static char popcount_table_8[256] = {
 };
 /* Table-driven popcount, with 8-bit tables */
 /* 6 ops plus 4 casts and 4 lookups, 0 long immediates, 4 stages */
-inline uint32_t
+uint32_t
 popcount(uint32_t x)
 {
     return popcount_table_8[(uint8_t)x] +

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ static char popcount_table_8[256] = {`
`261`	`261`	`};`
`262`	`262`	`/* Table-driven popcount, with 8-bit tables */`
`263`	`263`	`/* 6 ops plus 4 casts and 4 lookups, 0 long immediates, 4 stages */`
`264`		`-inline uint32_t`
	`264`	`+uint32_t`
`265`	`265`	`popcount(uint32_t x)`
`266`	`266`	`{`
`267`	`267`	`return popcount_table_8[(uint8_t)x] +`