Skip to content

Commit 315f7c1

Browse files
authored
Enable upstream spec tests requiring block parameters (WebAssembly#7151)
Now that WebAssembly#7149 added support for parsing block parameters, we can run additional spec tests that previously failed.
1 parent 0272a27 commit 315f7c1

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Current Trunk
1818
- BinaryenSelect no longer takes a type parameter.
1919
- AutoDrop APIs have been removed.
2020
- Binaryen now supports parsing control flow structures with parameter types by
21-
lowering them away in the parsers..
21+
lowering them away in the parsers.
2222

2323
v120
2424
----

scripts/test/shared.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,6 @@ def get_tests(test_dir, extensions=[], recursive=False):
416416
'address.wast', # 64-bit offset allowed by memory64
417417
'align.wast', # Alignment bit 6 used by multi-memory
418418
'binary.wast', # memory.grow reserved byte a LEB in multi-memory
419-
'block.wast', # Requires block parameters
420419
'bulk.wast', # Requires table.init abbreviation with implicit table
421420
'comments.wast', # Issue with carriage returns being treated as newlines
422421
'const.wast', # Hex float constant not recognized as out of range
@@ -425,22 +424,19 @@ def get_tests(test_dir, extensions=[], recursive=False):
425424
'elem.wast', # Requires table.init abbreviation with implicit table
426425
'f32.wast', # Adding -0 and -nan should give a canonical NaN
427426
'f64.wast', # Adding -0 and -nan should give a canonical NaN
428-
'fac.wast', # Requires block parameters (on a loop)
429427
'float_exprs.wast', # Adding 0 and NaN should give canonical NaN
430428
'float_misc.wast', # Rounding wrong on f64.sqrt
431429
'func.wast', # Duplicate parameter names not properly rejected
432430
'global.wast', # Globals allowed to refer to previous globals by GC
433-
'if.wast', # Requires block parameters (on an if)
431+
'if.wast', # Requires more precise unreachable validation
434432
'imports.wast', # Requires wast `register` support
435433
'linking.wast', # Requires wast `register` support
436-
'loop.wast', # Requires block parameters (on a loop)
437434
'memory.wast', # Multiple memories now allowed
438435
'annotations.wast', # String annotations IDs should be allowed
439436
'id.wast', # Empty IDs should be disallowed
440437
'throw.wast', # Requires try_table interpretation
441438
'try_catch.wast', # Requires wast `register` support
442439
'tag.wast', # Non-empty tag results allowed by stack switching
443-
'throw_ref.wast', # Requires block parameters (on an if)
444440
'try_table.wast', # Requires try_table interpretation
445441
'br_on_non_null.wast', # Requires sending values on br_on_non_null
446442
'br_on_null.wast', # Requires sending values on br_on_null

scripts/test/wasm2js.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
wasm2js_skipped_tests = [
3131
'empty_imported_table.wast',
3232
'br.wast', # depends on multivalue
33+
'fac.wast', # depends on mutlivalue
3334
'br_table.wast', # needs support for externref in assert_return
3435
]
3536

0 commit comments

Comments
 (0)